mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: Kernel development list <linux-kernel@vger.kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: sysfs lockdep complaint
Date: Sat, 20 Feb 2010 16:07:08 +0100	[thread overview]
Message-ID: <1266678428.32309.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100220150327.GG3000@hack>

On Sat, 2010-02-20 at 23:03 +0800, Américo Wang wrote:
> --- a/drivers/macintosh/windfarm_smu_controls.c
> +++ b/drivers/macintosh/windfarm_smu_controls.c
> @@ -173,6 +173,7 @@ static struct smu_fan_control
> *smu_fan_create(struct device_node *node,
>  
>  	fct->fan_type = pwm_fan;
>  	fct->ctrl.type = pwm_fan ? WF_CONTROL_PWM_FAN : WF_CONTROL_RPM_FAN;
> +	sysfs_attr_init(&fct->ctrl.attr);

hmm.

drivers/macintosh/windfarm_smu_controls.c: In function ‘smu_fan_create’:
drivers/macintosh/windfarm_smu_controls.c:176: error: ‘struct device_attribute’ has no member named ‘key’


johannes


  reply	other threads:[~2010-02-20 15:07 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-18  9:32 Johannes Berg
2010-02-20  9:26 ` Américo Wang
2010-02-20 11:13   ` Johannes Berg
2010-02-20 13:54     ` Américo Wang
2010-02-20 14:00       ` Johannes Berg
2010-02-20 11:20   ` Johannes Berg
2010-02-20 13:51     ` Américo Wang
2010-02-20 13:58       ` Johannes Berg
2010-02-20 15:16         ` Américo Wang
2010-02-20 14:01       ` Johannes Berg
2010-02-20 15:03         ` Américo Wang
2010-02-20 15:07           ` Johannes Berg [this message]
2010-02-20 15:08           ` Johannes Berg
2010-02-20 15:20             ` Américo Wang
2010-02-20 15:28               ` Johannes Berg
2010-02-20 15:31                 ` Johannes Berg
2010-02-20 15:44                   ` Américo Wang
2010-02-20 15:44                     ` Johannes Berg
2010-02-20 15:40                 ` Américo Wang
2010-02-20 15:41                   ` [PATCH] module: init sysfs attributes Johannes Berg
2010-02-20 15:43                   ` [PATCH] windfarm: " Johannes Berg
2010-02-24  2:49                     ` Benjamin Herrenschmidt
2010-02-24  7:32                       ` Johannes Berg
2010-02-24  7:34                         ` Américo Wang
2010-02-24  9:12                           ` Johannes Berg
2010-02-25  1:43                             ` Américo Wang
2010-03-08  7:46                               ` Johannes Berg
2010-02-24 13:24                           ` Greg KH
2010-02-25  1:46                             ` Américo Wang
2010-02-20 15:14           ` sysfs lockdep complaint Johannes Berg
2010-02-20 15:31             ` Américo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266678428.32309.0.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome