mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: Kernel development list <linux-kernel@vger.kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Greg KH <greg@kroah.com>
Subject: [PATCH] module: init sysfs attributes
Date: Sat, 20 Feb 2010 16:41:52 +0100	[thread overview]
Message-ID: <1266680512.17363.6.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100220154049.GM3000@hack>

This is required for lockdep.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 kernel/module.c                           |    3 +++

--- wireless-testing.orig/kernel/module.c	2010-02-20 16:16:52.740706797 +0100
+++ wireless-testing/kernel/module.c	2010-02-20 16:22:52.499698256 +0100
@@ -1085,6 +1085,7 @@ static void add_sect_attrs(struct module
 		sect_attrs->nsections++;
 		sattr->mattr.show = module_sect_show;
 		sattr->mattr.store = NULL;
+		sysfs_attr_init(&sattr->mattr.attr);
 		sattr->mattr.attr.name = sattr->name;
 		sattr->mattr.attr.mode = S_IRUGO;
 		*(gattr++) = &(sattr++)->mattr.attr;
@@ -1178,6 +1179,7 @@ static void add_notes_attrs(struct modul
 		if (sect_empty(&sechdrs[i]))
 			continue;
 		if (sechdrs[i].sh_type == SHT_NOTE) {
+			sysfs_bin_attr_init(nattr);
 			nattr->attr.name = mod->sect_attrs->attrs[loaded].name;
 			nattr->attr.mode = S_IRUGO;
 			nattr->size = sechdrs[i].sh_size;
@@ -1250,6 +1252,7 @@ int module_add_modinfo_attrs(struct modu
 		if (!attr->test ||
 		    (attr->test && attr->test(mod))) {
 			memcpy(temp_attr, attr, sizeof(*temp_attr));
+			sysfs_attr_init(&temp_attr->attr);
 			error = sysfs_create_file(&mod->mkobj.kobj,&temp_attr->attr);
 			++temp_attr;
 		}



  reply	other threads:[~2010-02-20 15:41 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-18  9:32 sysfs lockdep complaint Johannes Berg
2010-02-20  9:26 ` Américo Wang
2010-02-20 11:13   ` Johannes Berg
2010-02-20 13:54     ` Américo Wang
2010-02-20 14:00       ` Johannes Berg
2010-02-20 11:20   ` Johannes Berg
2010-02-20 13:51     ` Américo Wang
2010-02-20 13:58       ` Johannes Berg
2010-02-20 15:16         ` Américo Wang
2010-02-20 14:01       ` Johannes Berg
2010-02-20 15:03         ` Américo Wang
2010-02-20 15:07           ` Johannes Berg
2010-02-20 15:08           ` Johannes Berg
2010-02-20 15:20             ` Américo Wang
2010-02-20 15:28               ` Johannes Berg
2010-02-20 15:31                 ` Johannes Berg
2010-02-20 15:44                   ` Américo Wang
2010-02-20 15:44                     ` Johannes Berg
2010-02-20 15:40                 ` Américo Wang
2010-02-20 15:41                   ` Johannes Berg [this message]
2010-02-20 15:43                   ` [PATCH] windfarm: init sysfs attributes Johannes Berg
2010-02-24  2:49                     ` Benjamin Herrenschmidt
2010-02-24  7:32                       ` Johannes Berg
2010-02-24  7:34                         ` Américo Wang
2010-02-24  9:12                           ` Johannes Berg
2010-02-25  1:43                             ` Américo Wang
2010-03-08  7:46                               ` Johannes Berg
2010-02-24 13:24                           ` Greg KH
2010-02-25  1:46                             ` Américo Wang
2010-02-20 15:14           ` sysfs lockdep complaint Johannes Berg
2010-02-20 15:31             ` Américo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266680512.17363.6.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ebiederm@xmission.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome