[PATCH] scripts/get_maintainer.pl: Fix possible infinite loop

[PATCH] scripts/get_maintainer.pl: Fix possible infinite loop

[Joe Perches]

If MAINTAINERS section entries are misformatted,
it was possible to have an infinite loop.

Correct the defect by always moving at least one entry
forward in parsing the MAINTAINERS file.

Signed-off-by: Joe Perches <joe@perches.com>
---
 scripts/get_maintainer.pl |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 2f3230d..4f2ec25 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -340,8 +340,11 @@ foreach my $file (@files) {
 	    }
 	}
 
-	$tvi += ($end - $start);
-
+	if ($end <= $start) {
+	    $tvi++;
+	} else {
+	    $tvi += ($end - $start);
+	}
     }
 
     foreach my $line (sort {$hash{$b} <=> $hash{$a}} keys %hash) {
-- 
1.7.0.14.g7e948

[PATCH V2] scripts/get_maintainer.pl: Fix possible infinite loop

[Joe Perches]

This is simpler.

If MAINTAINERS section entries are misformatted,
it was possible to have an infinite loop.

Correct the defect by always moving the index
to the end of section + 1

Also, exit check for exclude as soon as possible.

Signed-off-by: Joe Perches <joe@perches.com>

 scripts/get_maintainer.pl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 2f3230d..049c419 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -314,6 +314,7 @@ foreach my $file (@files) {
 		if ($type eq 'X') {
 		    if (file_match_pattern($file, $value)) {
 			$exclude = 1;
+			last;
 		    }
 		}
 	    }
@@ -340,8 +341,7 @@ foreach my $file (@files) {
 	    }
 	}
 
-	$tvi += ($end - $start);
-
+	$tvi = $end + 1;
     }
 
     foreach my $line (sort {$hash{$b} <=> $hash{$a}} keys %hash) {