From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: sparse checking prevented by "net: fix kmemcheck annotations"
Date: Mon, 01 Mar 2010 14:09:26 +0100 [thread overview]
Message-ID: <1267448966.3039.22.camel@edumazet-laptop> (raw)
In-Reply-To: <4B8BAE79.9000609@s5r6.in-berlin.de>
Le lundi 01 mars 2010 à 13:09 +0100, Stefan Richter a écrit :
> Hi all,
>
> the post 2.6.32-rc5, pre 2.6.32-rc6 commit 14d18a81 causes a serious
> regression for sparse checks: make C=1 CF="-D__CHECK_ENDIAN__" now
> causes sparse to log
>
> include/linux/skbuff.h:357:41: error: invalid bitfield specifier for
> type restricted __be16.
>
>
> I reported this already shortly after this hit the mainline. But back
> then I didn't notice that this sparse error causes sparse to remain
> silent on all subsequent warnings in a file!
>
> We need to either change sparse to accept this bogus bit field that
> occurs in skbuff.h (__be16 protocol:16;), silently or with a warning, or
> revert this kmemcheck annotation.
>
> ("We" == preferably Eric :-)
>
> skbuff.h is included by lots of drivers, even ones that are not even
> networking drivers, notably DVB drivers. None of these drivers can be
> checked with sparse's __CHECK_ENDIAN__ at the moment.
Hi Stefan
I believe kmemcheck side effects were solved by commit e992cd9b72a18122
(kmemcheck: make bitfield annotations truly no-ops when disabled),
so there is no problem to partially revert the patch and fix this
problem.
Thanks !
[PATCH] net: fix protocol sk_buff field
Commit e992cd9b72a18 (kmemcheck: make bitfield annotations truly no-ops
when disabled) allows us to revert a workaround we did in the past to
not add holes in sk_buff structure.
This patch partially reverts commit 14d18a81b5171
(net: fix kmemcheck annotations) so that sparse doesnt complain:
include/linux/skbuff.h:357:41: error: invalid bitfield specifier for
type restricted __be16.
Reported-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index ae836fd..b40f56b 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -354,8 +354,8 @@ struct sk_buff {
ipvs_property:1,
peeked:1,
nf_trace:1;
- __be16 protocol:16;
kmemcheck_bitfield_end(flags1);
+ __be16 protocol;
void (*destructor)(struct sk_buff *skb);
#if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)
next prev parent reply other threads:[~2010-03-01 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 12:09 Stefan Richter
2010-03-01 13:09 ` Eric Dumazet [this message]
2010-03-01 16:18 ` Stefan Richter
2010-03-02 2:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267448966.3039.22.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®