From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux-kernel@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: sparse checking prevented by "net: fix kmemcheck annotations"
Date: Mon, 01 Mar 2010 13:09:29 +0100 [thread overview]
Message-ID: <4B8BAE79.9000609@s5r6.in-berlin.de> (raw)
Hi all,
the post 2.6.32-rc5, pre 2.6.32-rc6 commit 14d18a81 causes a serious
regression for sparse checks: make C=1 CF="-D__CHECK_ENDIAN__" now
causes sparse to log
include/linux/skbuff.h:357:41: error: invalid bitfield specifier for
type restricted __be16.
I reported this already shortly after this hit the mainline. But back
then I didn't notice that this sparse error causes sparse to remain
silent on all subsequent warnings in a file!
We need to either change sparse to accept this bogus bit field that
occurs in skbuff.h (__be16 protocol:16;), silently or with a warning, or
revert this kmemcheck annotation.
("We" == preferably Eric :-)
skbuff.h is included by lots of drivers, even ones that are not even
networking drivers, notably DVB drivers. None of these drivers can be
checked with sparse's __CHECK_ENDIAN__ at the moment.
--
Stefan Richter
-=====-==-=- --== ----=
http://arcgraph.de/sr/
next reply other threads:[~2010-03-01 12:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 12:09 Stefan Richter [this message]
2010-03-01 13:09 ` Eric Dumazet
2010-03-01 16:18 ` Stefan Richter
2010-03-02 2:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8BAE79.9000609@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®