* [PATCH] anon_inodes: mark the anon inode private
@ 2010-03-10 3:23 Eric Paris
2010-03-10 4:53 ` James Morris
0 siblings, 1 reply; 2+ messages in thread
From: Eric Paris @ 2010-03-10 3:23 UTC (permalink / raw)
To: linux-kernel, selinux; +Cc: torvalds, sds, viro, jmorris
Inotify was switched to use anon_inode instead of its own private filesystem
which only had one inode in commit c44dcc56d2b5c7 "switch inotify_user to
anon_inode"
The problem with this is that now the inotify inode is not a distinct inode
which can be managed by LSMs. userspace tools which use inotify were allowed
to use the inotify inode but may not have had permission to do read/write type
operations on the anon_inode. After looking at the anon_inode and its users
it looks like the best solution is to just mark the anon_inode as S_PRIVATE
so the security system will ignore it.
Signed-off-by: Eric Paris <eparis@redhat.com>
---
fs/anon_inodes.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c
index 9f0bf13..2de0095 100644
--- a/fs/anon_inodes.c
+++ b/fs/anon_inodes.c
@@ -209,6 +209,7 @@ static struct inode *anon_inode_mkinode(void)
inode->i_mode = S_IRUSR | S_IWUSR;
inode->i_uid = current_fsuid();
inode->i_gid = current_fsgid();
+ inode->i_flags |= S_PRIVATE;
inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
return inode;
}
--
1.6.5.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] anon_inodes: mark the anon inode private
2010-03-10 3:23 [PATCH] anon_inodes: mark the anon inode private Eric Paris
@ 2010-03-10 4:53 ` James Morris
0 siblings, 0 replies; 2+ messages in thread
From: James Morris @ 2010-03-10 4:53 UTC (permalink / raw)
To: Eric Paris; +Cc: linux-kernel, selinux, torvalds, sds, viro
On Tue, 9 Mar 2010, Eric Paris wrote:
> Inotify was switched to use anon_inode instead of its own private filesystem
> which only had one inode in commit c44dcc56d2b5c7 "switch inotify_user to
> anon_inode"
>
> The problem with this is that now the inotify inode is not a distinct inode
> which can be managed by LSMs. userspace tools which use inotify were allowed
> to use the inotify inode but may not have had permission to do read/write type
> operations on the anon_inode. After looking at the anon_inode and its users
> it looks like the best solution is to just mark the anon_inode as S_PRIVATE
> so the security system will ignore it.
>
> Signed-off-by: Eric Paris <eparis@redhat.com>
Acked-by: James Morris <jmorris@namei.org>
> ---
> fs/anon_inodes.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c
> index 9f0bf13..2de0095 100644
> --- a/fs/anon_inodes.c
> +++ b/fs/anon_inodes.c
> @@ -209,6 +209,7 @@ static struct inode *anon_inode_mkinode(void)
> inode->i_mode = S_IRUSR | S_IWUSR;
> inode->i_uid = current_fsuid();
> inode->i_gid = current_fsgid();
> + inode->i_flags |= S_PRIVATE;
> inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
> return inode;
> }
> --
> 1.6.5.3
>
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-10 4:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-10 3:23 [PATCH] anon_inodes: mark the anon inode private Eric Paris
2010-03-10 4:53 ` James Morris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®