* [PATCH] get_maintainer: Repair STDIN usage
@ 2010-03-10 4:19 Wolfram Sang
2010-03-10 8:28 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2010-03-10 4:19 UTC (permalink / raw)
To: linux-kernel; +Cc: Wolfram Sang, Stephen Hemminger, Joe Perches
Commit 22dd5b0cba50a197aaa3bd2790a29ee2e8e4e372 (fix perlcritic warnings) broke
the ability to handle STDIN because the three argument version of open() cannot
handle standard IO-streams (which is mentioned in PerlBestPractices, too).
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Cc: Joe Perches <joe@perches.com>
---
Like checkpatch, the hints from perlcritic should be double-checked ;)
scripts/get_maintainer.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index f76f3d1..6f97a13 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -284,7 +284,7 @@ foreach my $file (@ARGV) {
my $file_cnt = @files;
my $lastfile;
- open(my $patch, '<', $file)
+ open(my $patch, "< $file")
or die "$P: Can't open $file: $!\n";
while (<$patch>) {
my $patch_line = $_;
--
1.7.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] get_maintainer: Repair STDIN usage
2010-03-10 4:19 [PATCH] get_maintainer: Repair STDIN usage Wolfram Sang
@ 2010-03-10 8:28 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2010-03-10 8:28 UTC (permalink / raw)
To: Wolfram Sang, Andrew Morton; +Cc: linux-kernel, Stephen Hemminger
On Wed, 2010-03-10 at 05:19 +0100, Wolfram Sang wrote:
> Commit 22dd5b0cba50a197aaa3bd2790a29ee2e8e4e372 (fix perlcritic warnings) broke
> the ability to handle STDIN because the three argument version of open() cannot
> handle standard IO-streams (which is mentioned in PerlBestPractices, too).
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Stephen Hemminger <shemminger@vyatta.com>
> Cc: Joe Perches <joe@perches.com>
Oh well.
Acked-by: Joe Perches <joe@perches.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-10 8:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-10 4:19 [PATCH] get_maintainer: Repair STDIN usage Wolfram Sang
2010-03-10 8:28 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®