mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Robin Holt <holt@sgi.com>, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [Patch] x86,pat Update the page flags for memtype atomically instead of using memtype_lock.
Date: Fri, 12 Mar 2010 18:05:23 -0800	[thread overview]
Message-ID: <1268445923.2793.206.camel@sbs-t61.sc.intel.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1003130250540.22855@localhost.localdomain>

On Fri, 2010-03-12 at 17:52 -0800, Thomas Gleixner wrote:
> On Fri, 12 Mar 2010, Suresh Siddha wrote:
> > Just wanted to make sure that we address the perf aspect even for non
> > RAM pages by converting the memtype_lock into rwlock before some one
> > else reports a similar issue for non RAM pages.
> 
> Care to explain why a rwlock is a good solution and which problem is
> solved by the conversion of a spinlock to a rwlock ?

Thomas, This is the original posting from Robin.

http://marc.info/?l=linux-kernel&m=126720623119649&w=2

lookup_memtype() currently takes the memtype spinlock. Changing this to
a readlock will allow multiple folks to go through this in parallel.

thanks,
suresh


  reply	other threads:[~2010-03-13  2:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-11 16:17 Robin Holt
2010-03-13  0:15 ` Suresh Siddha
2010-03-13  1:08   ` Thomas Gleixner
2010-03-13  1:46     ` Suresh Siddha
2010-03-13  1:52       ` Thomas Gleixner
2010-03-13  2:05         ` Suresh Siddha [this message]
2010-03-15 21:11   ` Robin Holt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268445923.2793.206.camel@sbs-t61.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=holt@sgi.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=venkatesh.pallipadi@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®