From: Thomas Gleixner <tglx@linutronix.de>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Robin Holt <holt@sgi.com>, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [Patch] x86,pat Update the page flags for memtype atomically instead of using memtype_lock.
Date: Sat, 13 Mar 2010 02:08:51 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1003130204560.22855@localhost.localdomain> (raw)
In-Reply-To: <1268439313.2793.148.camel@sbs-t61.sc.intel.com>
On Fri, 12 Mar 2010, Suresh Siddha wrote:
> On Thu, 2010-03-11 at 08:17 -0800, Robin Holt wrote:
> > Changes since -V1:
> > 1) Introduce atomically setting and clearing the page flags and not
> > using the global memtype_lock to protect page->flags.
> >
> > 2) This allowed me the opportunity to convert the rwlock back into a
> > spinlock and not affect _MY_ tests performance as all the pages my test
> > was utilizing are tracked by struct pages.
>
> Can you also include this spinlock to rwlock conversion, which can be
> used for non RAM pages as a second patch?
spinlock -> rwlock conversion ? I hope you meant it the other way
round as Robin said in #2 :)
And yes it should be a separate patch.
Thanks,
tglx
next prev parent reply other threads:[~2010-03-13 1:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 16:17 Robin Holt
2010-03-13 0:15 ` Suresh Siddha
2010-03-13 1:08 ` Thomas Gleixner [this message]
2010-03-13 1:46 ` Suresh Siddha
2010-03-13 1:52 ` Thomas Gleixner
2010-03-13 2:05 ` Suresh Siddha
2010-03-15 21:11 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1003130204560.22855@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=holt@sgi.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=venkatesh.pallipadi@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®