From: Daniel Walker <dwalker@codeaurora.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Chihau Chau <chihau@gmail.com>,
gregkh@suse.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: dream: generic_gpio: Use linux instead of asm uaccess.h
Date: Mon, 15 Mar 2010 15:09:51 -0700 [thread overview]
Message-ID: <1268690991.10000.24.camel@c-dwalke-linux.qualcomm.com> (raw)
In-Reply-To: <20100315053352.GC11552@elf.ucw.cz>
On Mon, 2010-03-15 at 06:33 +0100, Pavel Machek wrote:
> On Mon 2010-03-15 00:05:55, Chihau Chau wrote:
> > From: Chihau Chau <chihau@gmail.com>
> >
> > This is moving toward using <linux/uaccess.h> instead of the old
> > <asm/uaccess.h> file.
>
> Changelog does not match the patch.
>
> ...plus, was the patch actually tested?
> Pavel
>
> > --- a/drivers/staging/dream/generic_gpio.c
> > +++ b/drivers/staging/dream/generic_gpio.c
We need to do some sort of staging re-sync .. This file for instance
doesn't exist in the Google's tree any longer .. They moved to gpiolib,
although they still need cleanups on top of that.
Daniel
next prev parent reply other threads:[~2010-03-15 22:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 3:05 Chihau Chau
2010-03-15 5:33 ` Pavel Machek
2010-03-15 18:08 ` Chihau Chau
2010-03-15 20:17 ` Pavel Machek
2010-03-16 18:45 ` Chihau Chau
2010-03-15 22:09 ` Daniel Walker [this message]
2010-04-01 17:29 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268690991.10000.24.camel@c-dwalke-linux.qualcomm.com \
--to=dwalker@codeaurora.org \
--cc=chihau@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome