From: Pavel Machek <pavel@ucw.cz>
To: Daniel Walker <dwalker@codeaurora.org>
Cc: Chihau Chau <chihau@gmail.com>,
gregkh@suse.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: dream: generic_gpio: Use linux instead of asm uaccess.h
Date: Thu, 1 Apr 2010 19:29:49 +0200 [thread overview]
Message-ID: <20100401172949.GA2049@elf.ucw.cz> (raw)
In-Reply-To: <1268690991.10000.24.camel@c-dwalke-linux.qualcomm.com>
On Mon 2010-03-15 15:09:51, Daniel Walker wrote:
> On Mon, 2010-03-15 at 06:33 +0100, Pavel Machek wrote:
> > On Mon 2010-03-15 00:05:55, Chihau Chau wrote:
> > > From: Chihau Chau <chihau@gmail.com>
> > >
> > > This is moving toward using <linux/uaccess.h> instead of the old
> > > <asm/uaccess.h> file.
> >
> > Changelog does not match the patch.
> >
> > ...plus, was the patch actually tested?
> > Pavel
> >
> > > --- a/drivers/staging/dream/generic_gpio.c
> > > +++ b/drivers/staging/dream/generic_gpio.c
>
> We need to do some sort of staging re-sync .. This file for instance
> doesn't exist in the Google's tree any longer .. They moved to gpiolib,
> although they still need cleanups on top of that.
Yep. I hoped Google would just start using the stuff once it hit
staging, but...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2010-04-01 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 3:05 Chihau Chau
2010-03-15 5:33 ` Pavel Machek
2010-03-15 18:08 ` Chihau Chau
2010-03-15 20:17 ` Pavel Machek
2010-03-16 18:45 ` Chihau Chau
2010-03-15 22:09 ` Daniel Walker
2010-04-01 17:29 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100401172949.GA2049@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=chihau@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dwalker@codeaurora.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome