mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: gregkh@suse.de, Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jason Wessel <jason.wessel@windriver.com>,
	Alan Cox <alan@linux.intel.com>,
	Alan Stern <stern@rowland.harvard.edu>
Subject: [PATCH 3/5] usb-console: pass baud from console to the initial tty open
Date: Tue, 16 Mar 2010 16:05:44 -0500	[thread overview]
Message-ID: <1268773546-12457-4-git-send-email-jason.wessel@windriver.com> (raw)
In-Reply-To: <1268773546-12457-3-git-send-email-jason.wessel@windriver.com>

The usb console code has had a long standing problem of not being able
to pass the baud rate from the kernel argument console=ttyUSB0,BAUD
down to the initial tty open, unless you were willing to settle for
9600 baud.

The solution is to directly use tty_init_termios() in
usb_console_setup() as this will preserve any changes to the initial
termios setting on future opens.

CC: Greg Kroah-Hartman <gregkh@suse.de>
CC: Alan Cox <alan@linux.intel.com>
CC: Alan Stern <stern@rowland.harvard.edu>
CC: linux-usb@vger.kernel.org
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
 drivers/usb/serial/console.c |   22 ++++++++++------------
 1 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
index 4ea64fe..1ee6b2a 100644
--- a/drivers/usb/serial/console.c
+++ b/drivers/usb/serial/console.c
@@ -66,7 +66,7 @@ static int usb_console_setup(struct console *co, char *options)
 	struct usb_serial_port *port;
 	int retval;
 	struct tty_struct *tty = NULL;
-	struct ktermios *termios = NULL, dummy;
+	struct ktermios dummy;
 
 	dbg("%s", __func__);
 
@@ -141,15 +141,14 @@ static int usb_console_setup(struct console *co, char *options)
 				goto reset_open_count;
 			}
 			kref_init(&tty->kref);
-			termios = kzalloc(sizeof(*termios), GFP_KERNEL);
-			if (!termios) {
+			tty_port_tty_set(&port->port, tty);
+			tty->driver = usb_serial_tty_driver;
+			tty->index = co->index;
+			if (tty_init_termios(tty)) {
 				retval = -ENOMEM;
 				err("no more memory");
 				goto free_tty;
 			}
-			memset(&dummy, 0, sizeof(struct ktermios));
-			tty->termios = termios;
-			tty_port_tty_set(&port->port, tty);
 		}
 
 		/* only call the device specific open if this
@@ -161,16 +160,16 @@ static int usb_console_setup(struct console *co, char *options)
 
 		if (retval) {
 			err("could not open USB console port");
-			goto free_termios;
+			goto fail;
 		}
 
 		if (serial->type->set_termios) {
-			termios->c_cflag = cflag;
-			tty_termios_encode_baud_rate(termios, baud, baud);
+			tty->termios->c_cflag = cflag;
+			tty_termios_encode_baud_rate(tty->termios, baud, baud);
+			memset(&dummy, 0, sizeof(struct ktermios));
 			serial->type->set_termios(tty, port, &dummy);
 
 			tty_port_tty_set(&port->port, NULL);
-			kfree(termios);
 			kfree(tty);
 		}
 		set_bit(ASYNCB_INITIALIZED, &port->port.flags);
@@ -185,8 +184,7 @@ static int usb_console_setup(struct console *co, char *options)
 	mutex_unlock(&serial->disc_mutex);
 	return retval;
 
- free_termios:
-	kfree(termios);
+ fail:
 	tty_port_tty_set(&port->port, NULL);
  free_tty:
 	kfree(tty);
-- 
1.6.4.rc1


  reply	other threads:[~2010-03-16 21:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16 21:05 [PATCH 0/5] V2 usb console improvements series Jason Wessel
2010-03-16 21:05 ` [PATCH 1/5] tty_port,usb-console: Fix usb serial console open/close regression Jason Wessel
2010-03-16 21:05   ` [PATCH 2/5] usb-serial: Use tty_port version of console instead of the usb_serial_port version Jason Wessel
2010-03-16 21:05     ` Jason Wessel [this message]
2010-03-16 21:05       ` [PATCH 4/5] usb-hcd,usb-console: poll hcd device to force usb console writes Jason Wessel
2010-03-16 21:05         ` [PATCH 5/5] usb-serialy,sysrq: Run the sysrq handler in a tasklet Jason Wessel
2010-03-16 21:46         ` [PATCH 4/5] usb-hcd,usb-console: poll hcd device to force usb console writes Greg KH
2010-03-17  9:08         ` Johan Hovold
2010-03-17 14:38         ` Alan Stern
2010-03-16 21:23     ` [PATCH 2/5] usb-serial: Use tty_port version of console instead of the usb_serial_port version Greg KH
2010-03-16 21:34       ` [PATCH 2/5] usb-serial: Use tty_port version of consoleinstead " Jason Wessel
2010-03-16 21:23   ` [PATCH 1/5] tty_port,usb-console: Fix usb serial console open/close regression Greg KH
2010-03-16 21:34     ` [PATCH 1/5] tty_port,usb-console: Fix usb serial consoleopen/close regression Jason Wessel
2010-03-17 14:30 ` [PATCH 0/5] V2 usb console improvements series Alan Stern
2010-03-17 14:46   ` Jason Wessel
2010-03-17 15:34     ` Alan Stern
2010-03-19 11:59 ` Jon Smirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268773546-12457-4-git-send-email-jason.wessel@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®