From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
pm list <linux-pm@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Regression, post-2.6.34-rc1][PATCH] x86 / perf: Fix suspend to RAM on HP nx6325
Date: Sun, 21 Mar 2010 02:10:35 +0100 [thread overview]
Message-ID: <1269133835.9440.621.camel@laptop> (raw)
In-Reply-To: <201003202148.01312.rjw@sisk.pl>
On Sat, 2010-03-20 at 21:48 +0100, Rafael J. Wysocki wrote:
> On Saturday 20 March 2010, Linus Torvalds wrote:
> >
> > On Sat, 20 Mar 2010, Peter Zijlstra wrote:
> > >
> > > cpuhw = &per_cpu(cpu_hw_events, cpu);
> > > + if (!cpuhw)
> > > + return;
> >
> > How can an address-of expression be NULL?
> >
> > Yes, 'per_cpu()' is magic, but it shouldn't be possible to be _that_
> > magic. It's rather against the whole C model.
>
> Yeah.
>
> A field in the object pointed to by it can be NULL, though.
That's what I was aiming for,. might have missed it by a mile though :/
> The appended patch fixes the breakage for me too.
ok, works for me, thanks
next prev parent reply other threads:[~2010-03-21 1:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 14:07 Rafael J. Wysocki
2010-03-20 17:36 ` Peter Zijlstra
2010-03-20 17:47 ` Linus Torvalds
2010-03-20 20:48 ` Rafael J. Wysocki
2010-03-21 1:10 ` Peter Zijlstra [this message]
2010-03-21 17:31 ` Linus Torvalds
2010-03-21 20:51 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269133835.9440.621.camel@laptop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®