From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Peter Zijlstra <peterz@infradead.org>,
pm list <linux-pm@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Regression, post-2.6.34-rc1][PATCH] x86 / perf: Fix suspend to RAM on HP nx6325
Date: Sun, 21 Mar 2010 10:31:52 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1003211029480.18017@i5.linux-foundation.org> (raw)
In-Reply-To: <201003202148.01312.rjw@sisk.pl>
On Sat, 20 Mar 2010, Rafael J. Wysocki wrote:
>
> The appended patch fixes the breakage for me too.
Please don't use a 'goto' for something like this.
> raw_spin_lock(&amd_nb_lock);
>
> + if (!cpuhw->amd_nb)
> + goto unlock;
> +
> if (--cpuhw->amd_nb->refcnt == 0)
> kfree(cpuhw->amd_nb);
>
> cpuhw->amd_nb = NULL;
>
> + unlock:
> raw_spin_unlock(&amd_nb_lock);
> }
Just do
raw_spin_lock(&amd_nb_lock);
if (cpuhw->amd_nb) {
if (!--cpuhw->amd_nb->refcnt)
kfree(cpuhw->amd_nb);
cpuhw->amd_nb = NULL;
}
raw_spin_unlock(&amd_nb_lock);
instead. Much more readable.
Let's keep 'goto' for cases where we have error returns that we don't want
to nest, not trivial stuff like this.
Linus
next prev parent reply other threads:[~2010-03-21 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 14:07 Rafael J. Wysocki
2010-03-20 17:36 ` Peter Zijlstra
2010-03-20 17:47 ` Linus Torvalds
2010-03-20 20:48 ` Rafael J. Wysocki
2010-03-21 1:10 ` Peter Zijlstra
2010-03-21 17:31 ` Linus Torvalds [this message]
2010-03-21 20:51 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1003211029480.18017@i5.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®