* [PATCH 1/2] ntfs : Clean up ntfs_attr_extend_initialized
@ 2010-04-05 15:45 Minchan Kim
0 siblings, 0 replies; only message in thread
From: Minchan Kim @ 2010-04-05 15:45 UTC (permalink / raw)
To: Andrew Morton
Cc: Anton Altaparmakov, Al Viro, Christoph Hellwig, Jiri Kosina,
linux-ntfs-dev, linux-kernel
cached_page and lru_pvec have not been used.
Let's remove the arguments.
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
---
fs/ntfs/file.c | 9 ++-------
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
index b681c71..41ffdcc 100644
--- a/fs/ntfs/file.c
+++ b/fs/ntfs/file.c
@@ -97,9 +97,6 @@ static int ntfs_file_open(struct inode *vi, struct file *filp)
* the page at all. For a more detailed explanation see ntfs_truncate() in
* fs/ntfs/inode.c.
*
- * @cached_page and @lru_pvec are just optimizations for dealing with multiple
- * pages.
- *
* Return 0 on success and -errno on error. In the case that an error is
* encountered it is possible that the initialized size will already have been
* incremented some way towards @new_init_size but it is guaranteed that if
@@ -109,8 +106,7 @@ static int ntfs_file_open(struct inode *vi, struct file *filp)
* Locking: i_mutex on the vfs inode corrseponsind to the ntfs inode @ni must be
* held by the caller.
*/
-static int ntfs_attr_extend_initialized(ntfs_inode *ni, const s64 new_init_size,
- struct page **cached_page, struct pagevec *lru_pvec)
+static int ntfs_attr_extend_initialized(ntfs_inode *ni, const s64 new_init_size)
{
s64 old_init_size;
loff_t old_i_size;
@@ -1924,8 +1920,7 @@ static ssize_t ntfs_file_buffered_write(struct kiocb *iocb,
ll = ni->initialized_size;
read_unlock_irqrestore(&ni->size_lock, flags);
if (pos > ll) {
- err = ntfs_attr_extend_initialized(ni, pos, &cached_page,
- &lru_pvec);
+ err = ntfs_attr_extend_initialized(ni, pos);
if (err < 0) {
ntfs_error(vol->sb, "Cannot perform write to inode "
"0x%lx, attribute type 0x%x, because "
--
1.6.5
--
Kind regards,
Minchan Kim
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-04-05 15:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-05 15:45 [PATCH 1/2] ntfs : Clean up ntfs_attr_extend_initialized Minchan Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®