From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Arjan van de Ven <arjan@linux.jf.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Yanmin Zhang <yanmin_zhang@linux.jf.intel.com>,
Gautham R Shenoy <ego@in.ibm.com>
Subject: Re: [patch v2 1/2] sched: check for prev_cpu == this_cpu before calling wake_affine()
Date: Wed, 14 Apr 2010 13:45:23 -0700 [thread overview]
Message-ID: <1271277923.2875.35.camel@sbs-t61.sc.intel.com> (raw)
In-Reply-To: <1270189239.6513.78.camel@marge.simson.net>
On Thu, 2010-04-01 at 23:20 -0700, Mike Galbraith wrote:
> Do you have a compute load bouncing painfully which this patch cures?
>
> I have no strong objections, and the result is certainly easier on the
> eye. If I were making the decision, I'd want to see some numbers.
Mike, PeterZ,
Finally got sometime to get back to this and provide some data backing
up my patch under discussion. Here are my test results:
System is a two socket quad-core NHM-EP with SMT enabled and the
workload is specjbb2005.
Warehouses Throughput
tip tip+proposed-fix
1 35142 35027
2 73563 75977
3 105806 109836
4 133421 142490
5 152151 168888
6 164936 195392
7 184763 208155
8 192419 223846
PeterZ, I think the above clearly shows that we have a problem with the
current -tip code. Please consider the proposed patch (which can be
found at http://marc.info/?l=linux-kernel&m=127007936408754&w=2)
Mike, with the above data, can I have your Ack for the patch?
thanks,
suresh
next prev parent reply other threads:[~2010-04-14 20:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 22:19 Suresh Siddha
2010-03-08 22:19 ` [patch v2 2/2] sched: fix select_idle_sibling() logic in select_task_rq_fair() Suresh Siddha
2010-03-31 10:25 ` [patch v2 1/2] sched: check for prev_cpu == this_cpu before calling wake_affine() Peter Zijlstra
2010-03-31 23:47 ` Suresh Siddha
2010-04-01 5:32 ` Mike Galbraith
2010-04-01 21:04 ` Suresh Siddha
2010-04-02 6:20 ` Mike Galbraith
2010-04-02 17:05 ` Suresh Siddha
2010-04-02 19:43 ` Mike Galbraith
2010-04-14 20:45 ` Suresh Siddha [this message]
2010-04-15 5:17 ` Mike Galbraith
2010-04-20 8:46 ` Peter Zijlstra
2010-04-20 8:55 ` Peter Zijlstra
2010-04-20 17:03 ` Suresh Siddha
2010-04-23 10:50 ` [tip:sched/core] sched: Fix select_idle_sibling() logic in select_task_rq_fair() tip-bot for Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271277923.2875.35.camel@sbs-t61.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=arjan@linux.jf.intel.com \
--cc=efault@gmx.de \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=svaidy@linux.vnet.ibm.com \
--cc=yanmin_zhang@linux.jf.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®