mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg@redhat.com>
To: minyard@acm.org
Cc: openipmi-developer@lists.sourceforge.net, bjorn.helgaas@hp.com,
	linux-kernel@vger.kernel.org, Matthew Garrett <mjg@redhat.com>
Subject: [PATCH 3/3] ipmi: Change device discovery order
Date: Tue, 20 Apr 2010 14:40:28 -0400	[thread overview]
Message-ID: <1271788828-10231-3-git-send-email-mjg@redhat.com> (raw)
In-Reply-To: <1271788828-10231-2-git-send-email-mjg@redhat.com>

The ipmi spec provides an ordering for si discovery. Change the driver
to match.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
 drivers/char/ipmi/ipmi_si_intf.c |   21 +++++++++++----------
 1 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 95af023..a36cab1 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -3301,23 +3301,24 @@ static __devinit int init_ipmi_si(void)
 	}
 	mutex_unlock(&smi_infos_lock);
 
-#ifdef CONFIG_DMI
-	dmi_find_bmc();
+#ifdef CONFIG_PCI
+	rv = pci_register_driver(&ipmi_pci_driver);
+	if (rv)
+		printk(KERN_ERR
+		       "init_ipmi_si: Unable to register PCI driver: %d\n",
+		       rv);
 #endif
 
 #ifdef CONFIG_ACPI
-	spmi_find_bmc();
+	pnp_register_driver(&ipmi_pnp_driver);
 #endif
+
 #ifdef CONFIG_ACPI
-	pnp_register_driver(&ipmi_pnp_driver);
+	spmi_find_bmc();
 #endif
 
-#ifdef CONFIG_PCI
-	rv = pci_register_driver(&ipmi_pci_driver);
-	if (rv)
-		printk(KERN_ERR
-		       "init_ipmi_si: Unable to register PCI driver: %d\n",
-		       rv);
+#ifdef CONFIG_DMI
+	dmi_find_bmc();
 #endif
 
 #ifdef CONFIG_PPC_OF
-- 
1.6.5.2


  reply	other threads:[~2010-04-20 18:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-20 18:40 [PATCH 1/3] ipmi: Split device discovery and registration Matthew Garrett
2010-04-20 18:40 ` [PATCH 2/3] ipmi: Only register one si per bmc Matthew Garrett
2010-04-20 18:40   ` Matthew Garrett [this message]
2010-04-21 18:09   ` Corey Minyard
2010-04-21 18:21     ` Matthew Garrett
2010-04-21 20:03       ` Corey Minyard
2010-04-21 20:10         ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1271788828-10231-3-git-send-email-mjg@redhat.com \
    --to=mjg@redhat.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®