From: Steven Rostedt <rostedt@goodmis.org>
To: Pekka Paalanen <pq@iki.fi>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 3/4] tracing: Allow mmio tracer to display trace_printk() and other events
Date: Thu, 13 May 2010 15:42:41 -0400 [thread overview]
Message-ID: <1273779761.27703.1329.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1273763483.27703.991.camel@gandalf.stny.rr.com>
On Thu, 2010-05-13 at 11:11 -0400, Steven Rostedt wrote:
> > > How does that sound?
> >
> > That would be fine. Is it not redundant with what you said in
> > your first sentence?
> >
>
> Right now with this patch as is. When you enable the mmiotracer it
> clears the ring buffer. But if someone previously enabled an event (like
> sched_switch for example) then that event will appear in the output of
> the tracer.
>
> The user will need to disable that event and restart the mmiotracer so
> the output will not break the userspace tools. Is this OK?
>
> If not, then my suggestion is to have an mmiotracer option that keeps it
> from printing out any event except for the ones it knows about.
>
> The reason I added this patch in the first place was because Larry
> Finger was using the mmiotrace with trace_printk() and the current code
> does not print out the trace_printk() when mmiotracer is active.
Pekka,
Are you OK with this version of the patch or do you want me to add the
option as described above?
-- Steve
next prev parent reply other threads:[~2010-05-13 19:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 1:21 [PATCH 0/4] [GIT PULL] tracing: updates Steven Rostedt
2010-05-13 1:21 ` [PATCH 1/4] tracing: Fix function declarations if !CONFIG_STACKTRACE Steven Rostedt
2010-05-13 1:21 ` [PATCH 2/4] tracing/sched: Fix task states in sched switch event Steven Rostedt
2010-05-13 6:15 ` Ingo Molnar
2010-05-13 1:21 ` [PATCH 3/4] tracing: Allow mmio tracer to display trace_printk() and other events Steven Rostedt
2010-05-13 8:54 ` Pekka Paalanen
2010-05-13 12:15 ` Steven Rostedt
2010-05-13 12:29 ` Pekka Paalanen
2010-05-13 15:11 ` Steven Rostedt
2010-05-13 19:42 ` Steven Rostedt [this message]
2010-05-15 7:46 ` Pekka Paalanen
2010-05-16 1:29 ` Steven Rostedt
2010-05-13 1:21 ` [PATCH 4/4] tracing: Update branch trace to new event API Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273779761.27703.1329.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=Larry.Finger@lwfinger.net \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pq@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®