From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: b.reynal@virtualopensystems.com, alex.williamson@redhat.com,
eric.auger@linaro.org, dan.carpenter@oracle.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
xie.baoyou@zte.com.cn
Subject: Re: [PATCH] vfio: platform: mark symbols static where possible
Date: Thu, 01 Sep 2016 13:23:01 +0200 [thread overview]
Message-ID: <12741269.Soyf6M0mBp@wuerfel> (raw)
In-Reply-To: <1472728535-8584-1-git-send-email-baoyou.xie@linaro.org>
On Thursday, September 1, 2016 7:15:35 PM CEST Baoyou Xie wrote:
> We get a few warnings when building kernel with W=1:
> drivers/vfio/platform/vfio_platform_common.c:76:5: warning: no previous prototype for 'vfio_platform_acpi_call_reset' [-Wmissing-prototypes]
> drivers/vfio/platform/vfio_platform_common.c:98:6: warning: no previous prototype for 'vfio_platform_acpi_has_reset' [-Wmissing-prototypes]
> drivers/vfio/platform/vfio_platform_common.c:640:5: warning: no previous prototype for 'vfio_platform_of_probe' [-Wmissing-prototypes]
> drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:59:5: warning: no previous prototype for 'vfio_platform_amdxgbe_reset' [-Wmissing-prototypes]
> drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c:60:5: warning: no previous prototype for 'vfio_platform_calxedaxgmac_reset' [-Wmissing-prototypes]
> ....
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2016-09-01 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 11:15 Baoyou Xie
2016-09-01 11:23 ` Arnd Bergmann [this message]
2016-09-01 11:41 ` Auger Eric
2016-09-01 12:09 ` Baptiste Reynal
2016-09-13 22:18 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12741269.Soyf6M0mBp@wuerfel \
--to=arnd@arndb.de \
--cc=alex.williamson@redhat.com \
--cc=b.reynal@virtualopensystems.com \
--cc=baoyou.xie@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=eric.auger@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®