From: Steven Rostedt <rostedt@goodmis.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@lst.de>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Li Zefan <lizf@cn.fujitsu.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Johannes Berg <johannes.berg@intel.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Tom Zanussi <tzanussi@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [RFC] Unified Ring Buffer (Next Generation)
Date: Wed, 19 May 2010 15:38:33 -0400 [thread overview]
Message-ID: <1274297913.26328.1057.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20100519192542.GD18073@basil.fritz.box>
On Wed, 2010-05-19 at 21:25 +0200, Andi Kleen wrote:
> > Perhaps, but the goal is actually to handle all the features of perf and
> > ftrace in a generic fashion.
>
> Ok so your goal is to only cover perf and ftrace and let all
> the other users be alone?
>
Yes, my goal is to unify perf and ftrace, but that's because that is
what I am working most on.
> >
> > You also bring up a point that I try very hard to get across. When
> > people think of a ring buffer, they think of the ones that they created
> > in CS101, not realizing that when you are dealing with production
> > systems, handling the requirements makes the buffering much more
> > complex.
>
> For most users the simple ones are totally adequate though.
>
> > Perhaps the answer is we are fine with more than one ring buffer. I'm OK
>
> That's what we already have in fact: kfifo, ftrace, perf, a couple
> of private ones all over.
>
> I think a couple of private ones could be converted to kfifo
> (I did some of that for my own code)
>
> But I don't really see how you can marry the simple kfifo world
> to the highend bells'n'whistles ftrace world. And even in the highend
> world there might be space for multiple specialized ones.
>
> On the other hand if the highend world had less overhead
> then at least some of the "higher end" kfifo users could start
> considering to use it.
If Mathieu can pull off the requirements that can handle all of ftrace
and perf in a light weight manner, then great. But if the end result is
still to much for these "private" users, then we should have a
"ring_buffer_lite", and perhaps even base it off of a kfifo itself.
Note, it would be nice to have a single location that (a) ring buffer(s)
reside at. This way if a developer has a need for a ring buffer then
they can have a single location to look for one.
Maybe the ring buffer code should go in lib/ringbuffers/ instead of
kernel/ringbuffer/.
-- Steve
next prev parent reply other threads:[~2010-05-19 19:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 17:51 Steven Rostedt
2010-05-19 18:10 ` Andi Kleen
2010-05-19 18:44 ` Steven Rostedt
2010-05-19 19:25 ` Andi Kleen
2010-05-19 19:38 ` Steven Rostedt [this message]
2010-05-19 18:47 ` Mathieu Desnoyers
2010-05-20 6:41 ` Andi Kleen
2010-05-20 13:48 ` Mathieu Desnoyers
2010-05-19 19:05 ` Mathieu Desnoyers
2010-05-20 9:31 ` [RFD] Future tracing/instrumentation directions Ingo Molnar
2010-05-20 10:07 ` Frederic Weisbecker
2010-05-20 11:07 ` Thomas Gleixner
2010-05-20 11:42 ` Ingo Molnar
2010-05-20 11:48 ` Ingo Molnar
2010-05-20 12:15 ` Frederic Weisbecker
2010-05-20 12:19 ` Theodore Tso
2010-05-20 11:36 ` Ingo Molnar
2010-05-20 13:06 ` Frederic Weisbecker
2010-05-20 14:38 ` Steven Rostedt
2010-05-20 15:04 ` Steven Rostedt
2010-05-20 20:12 ` Steven Rostedt
2010-05-21 17:49 ` Ingo Molnar
2010-05-24 20:13 ` Steven Rostedt
2010-05-21 9:24 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274297913.26328.1057.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=acme@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=fweisbec@gmail.com \
--cc=hch@lst.de \
--cc=johannes.berg@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®