* [PATCH v2 2/4] splice: direct_splice_actor() should not use pos in sd
@ 2010-05-26 14:43 Changli Gao
2010-05-28 9:37 ` Miklos Szeredi
0 siblings, 1 reply; 2+ messages in thread
From: Changli Gao @ 2010-05-26 14:43 UTC (permalink / raw)
To: Jens Axboe
Cc: Alexander Viro, Miklos Szeredi, linux-fsdevel, linux-kernel, Changli Gao
direct_splice_actor() should not use pos in sd
direct_splice_actor() shouldn't use sd->pos, as sd->pos is for file reading,
file->f_pos should be used instead.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
----
fs/splice.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/splice.c b/fs/splice.c
index 9e52de5..eb602cb 100644
--- a/fs/splice.c
+++ b/fs/splice.c
@@ -1232,7 +1232,8 @@ static int direct_splice_actor(struct pipe_inode_info *pipe,
{
struct file *file = sd->u.file;
- return do_splice_from(pipe, file, &sd->pos, sd->total_len, sd->flags);
+ return do_splice_from(pipe, file, &file->f_pos, sd->total_len,
+ sd->flags);
}
/**
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2 2/4] splice: direct_splice_actor() should not use pos in sd
2010-05-26 14:43 [PATCH v2 2/4] splice: direct_splice_actor() should not use pos in sd Changli Gao
@ 2010-05-28 9:37 ` Miklos Szeredi
0 siblings, 0 replies; 2+ messages in thread
From: Miklos Szeredi @ 2010-05-28 9:37 UTC (permalink / raw)
To: Changli Gao; +Cc: axboe, viro, mszeredi, linux-fsdevel, linux-kernel, xiaosuo
On Wed, 26 May 2010, Changli Gao wrote:
> direct_splice_actor() should not use pos in sd
>
> direct_splice_actor() shouldn't use sd->pos, as sd->pos is for file reading,
> file->f_pos should be used instead.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Acked-by: Miklos Szeredi <mszeredi@suse.cz>
> ----
> fs/splice.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/fs/splice.c b/fs/splice.c
> index 9e52de5..eb602cb 100644
> --- a/fs/splice.c
> +++ b/fs/splice.c
> @@ -1232,7 +1232,8 @@ static int direct_splice_actor(struct pipe_inode_info *pipe,
> {
> struct file *file = sd->u.file;
>
> - return do_splice_from(pipe, file, &sd->pos, sd->total_len, sd->flags);
> + return do_splice_from(pipe, file, &file->f_pos, sd->total_len,
> + sd->flags);
> }
>
> /**
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-28 9:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-05-26 14:43 [PATCH v2 2/4] splice: direct_splice_actor() should not use pos in sd Changli Gao
2010-05-28 9:37 ` Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®