From: Mike Sheldon <mike@mikeasoft.com>
To: greg@kroah.com, pavel@ucw.cz
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Mike Sheldon <mike@mikeasoft.com>
Subject: [PATCH 13/15] Staging: winbond: Replace printk usage with pr_info/pr_err
Date: Thu, 27 May 2010 00:39:50 +0100 [thread overview]
Message-ID: <1274917192-16962-13-git-send-email-mike@mikeasoft.com> (raw)
In-Reply-To: <1274917192-16962-1-git-send-email-mike@mikeasoft.com>
Patches wb35tx.c to replace printk usage (missing KERN_ levels) with appropriate pr_info and pr_err calls.
Signed-off-by: Mike Sheldon <mike@mikeasoft.com>
---
drivers/staging/winbond/wb35tx.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/staging/winbond/wb35tx.c
index bda7a91..5ae792c 100644
--- a/drivers/staging/winbond/wb35tx.c
+++ b/drivers/staging/winbond/wb35tx.c
@@ -33,7 +33,7 @@ static void Wb35Tx_complete(struct urb * pUrb)
struct wb35_tx *pWb35Tx = &pHwData->Wb35Tx;
struct wb35_mds *pMds = &adapter->Mds;
- printk("wb35: tx complete\n");
+ pr_info("wb35: tx complete\n");
// Variable setting
pWb35Tx->EP4vm_state = VM_COMPLETED;
pWb35Tx->EP4VM_status = pUrb->status; //Store the last result of Irp
@@ -49,7 +49,7 @@ static void Wb35Tx_complete(struct urb * pUrb)
// The URB is completed, check the result
if (pWb35Tx->EP4VM_status != 0) {
- printk("URB submission failed\n");
+ pr_err("URB submission failed\n");
pWb35Tx->EP4vm_state = VM_STOP;
goto error;
}
@@ -97,7 +97,7 @@ static void Wb35Tx(struct wbsoft_priv *adapter)
pWb35Tx->EP4vm_state = VM_RUNNING;
retv = usb_submit_urb(pUrb, GFP_ATOMIC);
if (retv<0) {
- printk("EP4 Tx Irp sending error\n");
+ pr_err("EP4 Tx Irp sending error\n");
goto cleanup;
}
@@ -154,14 +154,14 @@ void Wb35Tx_stop(struct hw_data * pHwData)
if (pWb35Tx->EP2vm_state == VM_RUNNING)
usb_unlink_urb( pWb35Tx->Tx2Urb ); // Only use unlink, let Wb35Tx_destrot to free them
#ifdef _PE_TX_DUMP_
- printk("EP2 Tx stop\n");
+ pr_info("EP2 Tx stop\n");
#endif
// Trying to canceling the Irp of EP4
if (pWb35Tx->EP4vm_state == VM_RUNNING)
usb_unlink_urb( pWb35Tx->Tx4Urb ); // Only use unlink, let Wb35Tx_destrot to free them
#ifdef _PE_TX_DUMP_
- printk("EP4 Tx stop\n");
+ pr_info("EP4 Tx stop\n");
#endif
}
@@ -183,7 +183,7 @@ void Wb35Tx_destroy(struct hw_data * pHwData)
usb_free_urb( pWb35Tx->Tx2Urb );
#ifdef _PE_TX_DUMP_
- printk("Wb35Tx_destroy OK\n");
+ pr_info("Wb35Tx_destroy OK\n");
#endif
}
@@ -230,7 +230,7 @@ static void Wb35Tx_EP2VM_complete(struct urb * pUrb)
//The Urb is completed, check the result
if (pWb35Tx->EP2VM_status != 0) {
- printk("EP2 IoCompleteRoutine return error\n");
+ pr_err("EP2 IoCompleteRoutine return error\n");
pWb35Tx->EP2vm_state= VM_STOP;
goto error;
}
@@ -280,7 +280,7 @@ static void Wb35Tx_EP2VM(struct wbsoft_priv *adapter)
if (retv < 0) {
#ifdef _PE_TX_DUMP_
- printk("EP2 Tx Irp sending error\n");
+ pr_err("EP2 Tx Irp sending error\n");
#endif
goto error;
}
--
1.7.0.4
next prev parent reply other threads:[~2010-05-26 23:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 23:39 [PATCH 01/15] Staging: winbond: Fix spacing around brackets and colons Mike Sheldon
2010-05-26 23:39 ` [PATCH 02/15] Staging: winbond: Replace C99 comments with C88 Mike Sheldon
2010-05-26 23:39 ` [PATCH 03/15] Staging: winbond: Fix spacing around brackets, braces, etc Mike Sheldon
2010-05-26 23:39 ` [PATCH 04/15] Staging: winbond: Replace printk usage with pr_info/pr_err Mike Sheldon
2010-05-26 23:39 ` [PATCH 05/15] Staging: winbond: Fix spacing around brackets, braces, etc Mike Sheldon
2010-05-26 23:39 ` [PATCH 06/15] Staging: winbond: Replace C99 comments with C88 Mike Sheldon
2010-05-26 23:39 ` [PATCH 07/15] Staging: winbond: Replace printk usage with pr_err Mike Sheldon
2010-05-26 23:39 ` [PATCH 08/15] Staging: winbond: Replace printk usage with pr_info/pr_err Mike Sheldon
2010-05-26 23:39 ` [PATCH 09/15] Staging: winbond: Fix spacing around brackets and pointers Mike Sheldon
2010-05-26 23:39 ` [PATCH 10/15] Staging: winbond: Replace C99 comments with C88 Mike Sheldon
2010-05-26 23:39 ` [PATCH 11/15] Staging: winbond: Fix spacing around brackets and pointers Mike Sheldon
2010-05-26 23:39 ` [PATCH 12/15] Staging: winbond: Replace C99 comments with C88 Mike Sheldon
2010-05-26 23:39 ` Mike Sheldon [this message]
2010-05-26 23:39 ` [PATCH 14/15] Staging: winbond: Replace printk usage with pr_info Mike Sheldon
2010-05-26 23:39 ` [PATCH 15/15] " Mike Sheldon
2010-06-18 17:03 ` [PATCH 01/15] Staging: winbond: Fix spacing around brackets and colons Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274917192-16962-13-git-send-email-mike@mikeasoft.com \
--to=mike@mikeasoft.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®