From: Mike Sheldon <mike@mikeasoft.com>
To: greg@kroah.com, pavel@ucw.cz
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Mike Sheldon <mike@mikeasoft.com>
Subject: [PATCH 08/15] Staging: winbond: Replace printk usage with pr_info/pr_err
Date: Thu, 27 May 2010 00:39:45 +0100 [thread overview]
Message-ID: <1274917192-16962-8-git-send-email-mike@mikeasoft.com> (raw)
In-Reply-To: <1274917192-16962-1-git-send-email-mike@mikeasoft.com>
Patches wb35rx.c to replace printk usage (missing KERN_ levels) with appropriate pr_info and pr_err calls.
Signed-off-by: Mike Sheldon <mike@mikeasoft.com>
---
drivers/staging/winbond/wb35rx.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/winbond/wb35rx.c b/drivers/staging/winbond/wb35rx.c
index efe82b1..38ad5bd 100644
--- a/drivers/staging/winbond/wb35rx.c
+++ b/drivers/staging/winbond/wb35rx.c
@@ -28,7 +28,7 @@ static void packet_came(struct ieee80211_hw *hw, char *pRxBufferAddress, int Pac
skb = dev_alloc_skb(PacketSize);
if (!skb) {
- printk("Not enough memory for packet, FIXME\n");
+ pr_err("Not enough memory for packet, FIXME\n");
return;
}
@@ -110,7 +110,7 @@ static u16 Wb35Rx_indicate(struct ieee80211_hw *hw)
/* Basic check for Rx length. Is length valid? */
if (PacketSize > MAX_PACKET_SIZE) {
#ifdef _PE_RX_DUMP_
- printk("Serious ERROR : Rx data size too long, size =%d\n", PacketSize);
+ pr_err("Serious ERROR : Rx data size too long, size =%d\n", PacketSize);
#endif
pWb35Rx->EP3vm_state = VM_STOP;
@@ -187,7 +187,7 @@ static void Wb35Rx_Complete(struct urb *urb)
/* The URB is completed, check the result */
if (pWb35Rx->EP3VM_status != 0) {
#ifdef _PE_USB_STATE_DUMP_
- printk("EP3 IoCompleteRoutine return error\n");
+ pr_err("EP3 IoCompleteRoutine return error\n");
#endif
pWb35Rx->EP3vm_state = VM_STOP;
goto error;
@@ -250,7 +250,7 @@ static void Wb35Rx(struct ieee80211_hw *hw)
if (!pWb35Rx->RxOwner[RxBufferId]) {
/* It's impossible to run here. */
#ifdef _PE_RX_DUMP_
- printk("Rx driver fifo unavailable\n");
+ pr_err("Rx driver fifo unavailable\n");
#endif
goto error;
}
@@ -263,7 +263,7 @@ static void Wb35Rx(struct ieee80211_hw *hw)
pWb35Rx->pDRx = kzalloc(MAX_USB_RX_BUFFER, GFP_ATOMIC);
if (!pWb35Rx->pDRx) {
- printk("w35und: Rx memory alloc failed\n");
+ pr_err("w35und: Rx memory alloc failed\n");
goto error;
}
pRxBufferAddress = pWb35Rx->pDRx;
@@ -278,7 +278,7 @@ static void Wb35Rx(struct ieee80211_hw *hw)
retv = usb_submit_urb(urb, GFP_ATOMIC);
if (retv != 0) {
- printk("Rx URB sending error\n");
+ pr_err("Rx URB sending error\n");
goto error;
}
return;
@@ -338,7 +338,7 @@ void Wb35Rx_stop(struct hw_data *pHwData)
if (pWb35Rx->EP3vm_state == VM_RUNNING) {
usb_unlink_urb(pWb35Rx->RxUrb); /* Only use unlink, let Wb35Rx_destroy to free them */
#ifdef _PE_RX_DUMP_
- printk("EP3 Rx stop\n");
+ pr_info("EP3 Rx stop\n");
#endif
}
}
@@ -356,7 +356,7 @@ void Wb35Rx_destroy(struct hw_data *pHwData)
if (pWb35Rx->RxUrb)
usb_free_urb(pWb35Rx->RxUrb);
#ifdef _PE_RX_DUMP_
- printk("Wb35Rx_destroy OK\n");
+ pr_info("Wb35Rx_destroy OK\n");
#endif
}
--
1.7.0.4
next prev parent reply other threads:[~2010-05-26 23:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 23:39 [PATCH 01/15] Staging: winbond: Fix spacing around brackets and colons Mike Sheldon
2010-05-26 23:39 ` [PATCH 02/15] Staging: winbond: Replace C99 comments with C88 Mike Sheldon
2010-05-26 23:39 ` [PATCH 03/15] Staging: winbond: Fix spacing around brackets, braces, etc Mike Sheldon
2010-05-26 23:39 ` [PATCH 04/15] Staging: winbond: Replace printk usage with pr_info/pr_err Mike Sheldon
2010-05-26 23:39 ` [PATCH 05/15] Staging: winbond: Fix spacing around brackets, braces, etc Mike Sheldon
2010-05-26 23:39 ` [PATCH 06/15] Staging: winbond: Replace C99 comments with C88 Mike Sheldon
2010-05-26 23:39 ` [PATCH 07/15] Staging: winbond: Replace printk usage with pr_err Mike Sheldon
2010-05-26 23:39 ` Mike Sheldon [this message]
2010-05-26 23:39 ` [PATCH 09/15] Staging: winbond: Fix spacing around brackets and pointers Mike Sheldon
2010-05-26 23:39 ` [PATCH 10/15] Staging: winbond: Replace C99 comments with C88 Mike Sheldon
2010-05-26 23:39 ` [PATCH 11/15] Staging: winbond: Fix spacing around brackets and pointers Mike Sheldon
2010-05-26 23:39 ` [PATCH 12/15] Staging: winbond: Replace C99 comments with C88 Mike Sheldon
2010-05-26 23:39 ` [PATCH 13/15] Staging: winbond: Replace printk usage with pr_info/pr_err Mike Sheldon
2010-05-26 23:39 ` [PATCH 14/15] Staging: winbond: Replace printk usage with pr_info Mike Sheldon
2010-05-26 23:39 ` [PATCH 15/15] " Mike Sheldon
2010-06-18 17:03 ` [PATCH 01/15] Staging: winbond: Fix spacing around brackets and colons Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274917192-16962-8-git-send-email-mike@mikeasoft.com \
--to=mike@mikeasoft.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®