mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: Add task activate/deactivate tracepoints
Date: Mon, 31 May 2010 12:37:33 -0400	[thread overview]
Message-ID: <1275323853.15884.14.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1275322715.27810.23323.camel@twins>

Expect slow responses from me today. It's a US Holiday.


On Mon, 2010-05-31 at 18:18 +0200, Peter Zijlstra wrote:
> On Mon, 2010-05-31 at 16:48 +0200, Frederic Weisbecker wrote:
> > > Should we maybe cure this and rely on sched_switch() to detect sleeps?
> > > It seems natural since only the current task can go to sleep, its just
> > > that the whole preempt state gets a bit iffy.
> 
> How about something like the below?
> 
> Steve, is that proper usage of CREATE_TRACE_POINT?
> 
> ---
> Subject: sched, trace: Fix sched_switch() prev_state argument
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date: Mon May 31 18:13:25 CEST 2010
> 
> For CONFIG_PREEMPT=y kernels the sched_switch(.prev_state) argument
> isn't useful because we can get preempted with current->state !=
> TASK_RUNNING without actually getting removed from the runqueue.
> 
> Cure this by treating all preempted tasks as runnable from the
> tracer's point of view.
> 
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> ---
>  include/trace/events/sched.h |   19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> Index: linux-2.6/include/trace/events/sched.h
> ===================================================================
> --- linux-2.6.orig/include/trace/events/sched.h
> +++ linux-2.6/include/trace/events/sched.h
> @@ -115,6 +115,23 @@ DEFINE_EVENT(sched_wakeup_template, sche
>  	     TP_PROTO(struct task_struct *p, int success),
>  	     TP_ARGS(p, success));
>  
> +#ifdef CREATE_TRACE_POINTS

I guess this could work. I can't think of anything that would cause this
to fail. But this is not exactly what the CREATE_TRACE_POINTS macro was
for.

Maybe we could make a CREATE_UTIL_FUNCTIONS macro that the
define_trace.h can unset like it does with CREATE_TRACE_POINTS before
recursively including the trace headers.

Maybe I'm a bit paranoid, but I'm a little nervous to extend the
CREATE_TRACE_POINTS macro to be used within the header to create utility
functions, although, currently I don't think there's anything
technically wrong in doing so.

-- Steve

> +static inline long __trace_sched_switch_state(struct task_struct *p)
> +{
> +	long state = p->state;
> +
> +#ifdef CONFIG_PREEMPT
> +	/*
> +	 * For all intents and purposes a preempted task is a running task.
> +	 */
> +	if (task_thread_info(p)->preempt_count & PREEMPT_ACTIVE)
> +		state = TASK_RUNNING;
> +#endif
> +
> +	return state;
> +}
> +#endif
> +
>  /*
>   * Tracepoint for task switches, performed by the scheduler:
>   */
> @@ -139,7 +156,7 @@ TRACE_EVENT(sched_switch,
>  		memcpy(__entry->next_comm, next->comm, TASK_COMM_LEN);
>  		__entry->prev_pid	= prev->pid;
>  		__entry->prev_prio	= prev->prio;
> -		__entry->prev_state	= prev->state;
> +		__entry->prev_state	= __trace_sched_switch_state(prev);
>  		memcpy(__entry->prev_comm, prev->comm, TASK_COMM_LEN);
>  		__entry->next_pid	= next->pid;
>  		__entry->next_prio	= next->prio;
> 



  reply	other threads:[~2010-05-31 16:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-28 14:26 Frederic Weisbecker
2010-05-28 15:15 ` Peter Zijlstra
2010-05-31  8:00   ` Ingo Molnar
2010-05-31  8:12     ` Peter Zijlstra
2010-05-31  8:54       ` Peter Zijlstra
2010-05-31 14:36         ` Frederic Weisbecker
2010-05-31 14:43           ` Peter Zijlstra
2010-05-31 14:48             ` Frederic Weisbecker
2010-05-31 16:18               ` Peter Zijlstra
2010-05-31 16:37                 ` Steven Rostedt [this message]
2010-05-31 18:28                   ` Peter Zijlstra
2010-05-31 19:14                     ` Steven Rostedt
2010-05-31 19:16                     ` Steven Rostedt
2010-05-31 16:51                 ` Frederic Weisbecker
2010-06-01  9:13                 ` [tip:sched/urgent] sched, trace: Fix sched_switch() prev_state argument tip-bot for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275323853.15884.14.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®