From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: Add task activate/deactivate tracepoints
Date: Mon, 31 May 2010 15:16:32 -0400 [thread overview]
Message-ID: <1275333392.15884.16.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1275330522.1645.523.camel@laptop>
On Mon, 2010-05-31 at 20:28 +0200, Peter Zijlstra wrote:
> On Mon, 2010-05-31 at 12:37 -0400, Steven Rostedt wrote:
> > Maybe I'm a bit paranoid, but I'm a little nervous to extend the
> > CREATE_TRACE_POINTS macro to be used within the header to create utility
> > functions, although, currently I don't think there's anything
> > technically wrong in doing so.
>
> Right, I can attest to the compile mess that results in not having
> it :-) Given that, I think we're fairly safe with stretching it like
> this, the compiler will yell real loud if you mess this up. So I'm not
> sure you need to be very paranoid about this.
Actually, I'm not worried about getting the utility functions right. I'm
actually more worried about extending TRACE_EVENT() and having this be a
thorn in our side when doing so.
-- Steve
next prev parent reply other threads:[~2010-05-31 19:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 14:26 Frederic Weisbecker
2010-05-28 15:15 ` Peter Zijlstra
2010-05-31 8:00 ` Ingo Molnar
2010-05-31 8:12 ` Peter Zijlstra
2010-05-31 8:54 ` Peter Zijlstra
2010-05-31 14:36 ` Frederic Weisbecker
2010-05-31 14:43 ` Peter Zijlstra
2010-05-31 14:48 ` Frederic Weisbecker
2010-05-31 16:18 ` Peter Zijlstra
2010-05-31 16:37 ` Steven Rostedt
2010-05-31 18:28 ` Peter Zijlstra
2010-05-31 19:14 ` Steven Rostedt
2010-05-31 19:16 ` Steven Rostedt [this message]
2010-05-31 16:51 ` Frederic Weisbecker
2010-06-01 9:13 ` [tip:sched/urgent] sched, trace: Fix sched_switch() prev_state argument tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275333392.15884.16.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®