mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: rusty@rustcorp.com.au
Cc: linux-kernel@vger.kernel.org, geert@linux-m68k.org,
	"Justin P. Mattock" <justinmattock@gmail.com>
Subject: [PATCH 5/6 v2]kernel:module.c variable 'nowarn' set but not used
Date: Sat, 19 Jun 2010 13:39:13 -0700	[thread overview]
Message-ID: <1276979953-24443-1-git-send-email-justinmattock@gmail.com> (raw)

This is a resend from the original, due to the original being wrong,
and having whitespace issues.
The below patch marks the variable nowarn __unused to satisfy gcc 4.6.0 from
giving this warning:
  CC      kernel/module.o
kernel/module.c: In function 'add_usage_links':
kernel/module.c:1343:6: warning: variable 'nowarn' set but not used
after doing this the warning message goes away, but checkpatch.pl
gives a warning about externs should be avoided, so am not sure
this is the right approach(but could be wrong).

 Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 kernel/module.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index 8c6b428..765bac5 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1340,7 +1340,7 @@ static void add_usage_links(struct module *mod)
 {
 #ifdef CONFIG_MODULE_UNLOAD
 	struct module_use *use;
-	int nowarn;
+	int nowarn __attribute__((unused));
 
 	mutex_lock(&module_mutex);
 	list_for_each_entry(use, &mod->target_list, target_list) {
-- 
1.7.1.rc1.21.gf3bd6


                 reply	other threads:[~2010-06-19 20:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276979953-24443-1-git-send-email-justinmattock@gmail.com \
    --to=justinmattock@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®