* [PATCH 5/6 v2]kernel:module.c variable 'nowarn' set but not used
@ 2010-06-19 20:39 Justin P. Mattock
0 siblings, 0 replies; only message in thread
From: Justin P. Mattock @ 2010-06-19 20:39 UTC (permalink / raw)
To: rusty; +Cc: linux-kernel, geert, Justin P. Mattock
This is a resend from the original, due to the original being wrong,
and having whitespace issues.
The below patch marks the variable nowarn __unused to satisfy gcc 4.6.0 from
giving this warning:
CC kernel/module.o
kernel/module.c: In function 'add_usage_links':
kernel/module.c:1343:6: warning: variable 'nowarn' set but not used
after doing this the warning message goes away, but checkpatch.pl
gives a warning about externs should be avoided, so am not sure
this is the right approach(but could be wrong).
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
kernel/module.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/module.c b/kernel/module.c
index 8c6b428..765bac5 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1340,7 +1340,7 @@ static void add_usage_links(struct module *mod)
{
#ifdef CONFIG_MODULE_UNLOAD
struct module_use *use;
- int nowarn;
+ int nowarn __attribute__((unused));
mutex_lock(&module_mutex);
list_for_each_entry(use, &mod->target_list, target_list) {
--
1.7.1.rc1.21.gf3bd6
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-06-19 20:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-19 20:39 [PATCH 5/6 v2]kernel:module.c variable 'nowarn' set but not used Justin P. Mattock
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®