mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@arm.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/3] perf parse-events: Make common term list to strbuf helper
Date: Wed, 30 Aug 2023 15:34:56 -0400	[thread overview]
Message-ID: <127766c6-033c-dedb-2c56-7e1e7f8bd01b@linux.intel.com> (raw)
In-Reply-To: <b976ef43-25ea-f24a-2c22-0976fafcf0f0@linux.intel.com>



On 2023-08-30 2:29 p.m., Liang, Kan wrote:
>> The problem
>> is how we encode terms of an event name, it is indistinguishable when
>> the of the user field is 1. I'll probably add something to fix this
>> later, but it only impacts debug output and perf list, so I'm not
>> overly worried. 
> It should be OK for the debug output.
>

Not just the debug output. It also impacts the perf list --detail.

With the patch,
perf list --detail | grep uops_retired.heavy -A 2
  uops_retired.heavy
       [Retired uops except the last uop of each instruction. Unit:
cpu_core]
        cpu_core/event=0xc2,period=0x1e8483,umask/

Without the patch,
perf list --detail | grep uops_retired.heavy -A 2
  uops_retired.heavy
       [Retired uops except the last uop of each instruction. Unit:
cpu_core]
        cpu_core/event=0xc2,period=0x1e8483,umask=0x1/

Thanks,
Kan




  reply	other threads:[~2023-08-30 20:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30  7:07 [PATCH v1 1/3] perf parse-events: Minor help message improvements Ian Rogers
2023-08-30  7:07 ` [PATCH v1 2/3] perf parse-events: Make common term list to strbuf helper Ian Rogers
2023-08-30 14:11   ` Liang, Kan
2023-08-30 14:40     ` Ian Rogers
2023-08-30 15:04       ` Ian Rogers
2023-08-30 18:29         ` Liang, Kan
2023-08-30 19:34           ` Liang, Kan [this message]
2023-08-30 21:12             ` Ian Rogers
2023-08-30  7:07 ` [PATCH v1 3/3] perf pmu: Remove str from perf_pmu_alias Ian Rogers
2023-08-31 18:32 ` [PATCH v1 1/3] perf parse-events: Minor help message improvements Liang, Kan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=127766c6-033c-dedb-2c56-7e1e7f8bd01b@linux.intel.com \
    --to=kan.liang@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®