From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@arm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] perf parse-events: Minor help message improvements
Date: Thu, 31 Aug 2023 14:32:35 -0400 [thread overview]
Message-ID: <3eda8956-f131-3772-1df5-c7c0fb7335f9@linux.intel.com> (raw)
In-Reply-To: <20230830070753.1821629-1-irogers@google.com>
The other thread address the only issue I found when I tested the patch
series on a hybrid machine.
https://lore.kernel.org/lkml/c2affcc9-468f-bf4c-a080-65b31e05a83f@linux.intel.com/
The patch series looks good.
Tested-by: Kan Liang <kan.liang@linux.intel.com>
Thanks,
Kan
On 2023-08-30 3:07 a.m., Ian Rogers wrote:
> Be more specific and fix a typo.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/util/parse-events.y | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index 3a9d4e2513b5..4a370c36a0d5 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -342,7 +342,7 @@ PE_NAME opt_pmu_config
> struct parse_events_error *error = parse_state->error;
> char *help;
>
> - if (asprintf(&help, "Unabled to find PMU or event on a PMU of '%s'", $1) < 0)
> + if (asprintf(&help, "Unable to find PMU or event on a PMU of '%s'", $1) < 0)
> help = NULL;
> parse_events_error__handle(error, @1.first_column,
> strdup("Bad event or PMU"),
> @@ -368,7 +368,7 @@ PE_NAME sep_dc
> struct parse_events_error *error = parse_state->error;
> char *help;
>
> - if (asprintf(&help, "Unabled to find PMU or event on a PMU of '%s'", $1) < 0)
> + if (asprintf(&help, "Unable to find event on a PMU of '%s'", $1) < 0)
> help = NULL;
> parse_events_error__handle(error, @1.first_column, strdup("Bad event name"), help);
> free($1);
prev parent reply other threads:[~2023-08-31 18:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 7:07 Ian Rogers
2023-08-30 7:07 ` [PATCH v1 2/3] perf parse-events: Make common term list to strbuf helper Ian Rogers
2023-08-30 14:11 ` Liang, Kan
2023-08-30 14:40 ` Ian Rogers
2023-08-30 15:04 ` Ian Rogers
2023-08-30 18:29 ` Liang, Kan
2023-08-30 19:34 ` Liang, Kan
2023-08-30 21:12 ` Ian Rogers
2023-08-30 7:07 ` [PATCH v1 3/3] perf pmu: Remove str from perf_pmu_alias Ian Rogers
2023-08-31 18:32 ` Liang, Kan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eda8956-f131-3772-1df5-c7c0fb7335f9@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®