* [PATCH 07/16] trivial: use ARRAY_SIZE
@ 2010-06-28 11:55 Kulikov Vasiliy
2010-07-20 15:13 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Kulikov Vasiliy @ 2010-06-28 11:55 UTC (permalink / raw)
To: trivial
Cc: Kernel Janitors, Jing Huang, James E.J. Bottomley,
Krishna Gudipati, Kulikov Vasiliy, linux-scsi, linux-kernel
Change sizeof(x) / sizeof(*x) to ARRAY_SIZE(x).
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/scsi/bfa/bfa_fcs.c | 10 ++++------
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/bfa/bfa_fcs.c b/drivers/scsi/bfa/bfa_fcs.c
index 3516172..153cb2a 100644
--- a/drivers/scsi/bfa/bfa_fcs.c
+++ b/drivers/scsi/bfa/bfa_fcs.c
@@ -86,7 +86,7 @@ bfa_fcs_attach(struct bfa_fcs_s *fcs, struct bfa_s *bfa, struct bfad_s *bfad,
bfa_attach_fcs(bfa);
fcbuild_init();
- for (i = 0; i < sizeof(fcs_modules) / sizeof(fcs_modules[0]); i++) {
+ for (i = 0; i < ARRAY_SIZE(fcs_modules); i++) {
mod = &fcs_modules[i];
if (mod->attach)
mod->attach(fcs);
@@ -102,7 +102,7 @@ bfa_fcs_init(struct bfa_fcs_s *fcs)
int i;
struct bfa_fcs_mod_s *mod;
- for (i = 0; i < sizeof(fcs_modules) / sizeof(fcs_modules[0]); i++) {
+ for (i = 0; i < ARRAY_SIZE(fcs_modules); i++) {
mod = &fcs_modules[i];
if (mod->modinit)
mod->modinit(fcs);
@@ -163,13 +163,11 @@ void
bfa_fcs_exit(struct bfa_fcs_s *fcs)
{
struct bfa_fcs_mod_s *mod;
- int nmods, i;
+ int i;
bfa_wc_init(&fcs->wc, bfa_fcs_exit_comp, fcs);
- nmods = sizeof(fcs_modules) / sizeof(fcs_modules[0]);
-
- for (i = 0; i < nmods; i++) {
+ for (i = 0; i < ARRAY_SIZE(fcs_modules); i++) {
mod = &fcs_modules[i];
if (mod->modexit) {
--
1.7.0.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 07/16] trivial: use ARRAY_SIZE
2010-06-28 11:55 [PATCH 07/16] trivial: use ARRAY_SIZE Kulikov Vasiliy
@ 2010-07-20 15:13 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2010-07-20 15:13 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: Kernel Janitors, Jing Huang, James E.J. Bottomley,
Krishna Gudipati, linux-scsi, linux-kernel
On Mon, 28 Jun 2010, Kulikov Vasiliy wrote:
> Change sizeof(x) / sizeof(*x) to ARRAY_SIZE(x).
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> drivers/scsi/bfa/bfa_fcs.c | 10 ++++------
> 1 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/bfa/bfa_fcs.c b/drivers/scsi/bfa/bfa_fcs.c
> index 3516172..153cb2a 100644
> --- a/drivers/scsi/bfa/bfa_fcs.c
> +++ b/drivers/scsi/bfa/bfa_fcs.c
> @@ -86,7 +86,7 @@ bfa_fcs_attach(struct bfa_fcs_s *fcs, struct bfa_s *bfa, struct bfad_s *bfad,
> bfa_attach_fcs(bfa);
> fcbuild_init();
>
> - for (i = 0; i < sizeof(fcs_modules) / sizeof(fcs_modules[0]); i++) {
> + for (i = 0; i < ARRAY_SIZE(fcs_modules); i++) {
> mod = &fcs_modules[i];
> if (mod->attach)
> mod->attach(fcs);
> @@ -102,7 +102,7 @@ bfa_fcs_init(struct bfa_fcs_s *fcs)
> int i;
> struct bfa_fcs_mod_s *mod;
>
> - for (i = 0; i < sizeof(fcs_modules) / sizeof(fcs_modules[0]); i++) {
> + for (i = 0; i < ARRAY_SIZE(fcs_modules); i++) {
> mod = &fcs_modules[i];
> if (mod->modinit)
> mod->modinit(fcs);
> @@ -163,13 +163,11 @@ void
> bfa_fcs_exit(struct bfa_fcs_s *fcs)
> {
> struct bfa_fcs_mod_s *mod;
> - int nmods, i;
> + int i;
>
> bfa_wc_init(&fcs->wc, bfa_fcs_exit_comp, fcs);
>
> - nmods = sizeof(fcs_modules) / sizeof(fcs_modules[0]);
> -
> - for (i = 0; i < nmods; i++) {
> + for (i = 0; i < ARRAY_SIZE(fcs_modules); i++) {
>
> mod = &fcs_modules[i];
> if (mod->modexit) {
I have folded this patch into the other bfa change you made, and applied.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-20 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-28 11:55 [PATCH 07/16] trivial: use ARRAY_SIZE Kulikov Vasiliy
2010-07-20 15:13 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®