From: Venkatesh Pallipadi <venki@google.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: LKML <linux-kernel@vger.kernel.org>,
Gautham R Shenoy <ego@in.ibm.com>,
Joel Schopp <jschopp@austin.ibm.com>,
Venkatesh Pallipadi <venki@google.com>
Subject: [PATCH] sched: Call update_group_power only for local_group
Date: Thu, 1 Jul 2010 16:12:22 -0700 [thread overview]
Message-ID: <1278025942-6750-1-git-send-email-venki@google.com> (raw)
commit 871e35b moved update_group_power() call in update_sg_lb_stats(),
resulting in it being called for each group, even though it only updates
the power of local group. As a result we have frequent redundant
update_group_power() calls.
Move it back under "if (local_group)" condition.
This reduces the number of calls to update_group_power by a factor of 4
on my 4 core in 4 NUMA nodes test system.
Signed-off-by: Venkatesh Pallipadi <venki@google.com>
---
kernel/sched_fair.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index a878b53..369d53d 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -2359,8 +2359,11 @@ static inline void update_sg_lb_stats(struct sched_domain *sd,
unsigned int balance_cpu = -1, first_idle_cpu = 0;
unsigned long avg_load_per_task = 0;
- if (local_group)
+ if (local_group) {
balance_cpu = group_first_cpu(group);
+ update_group_power(sd, this_cpu);
+ }
+
/* Tally up the load of all CPUs in the group */
max_cpu_load = 0;
@@ -2406,8 +2409,6 @@ static inline void update_sg_lb_stats(struct sched_domain *sd,
return;
}
- update_group_power(sd, this_cpu);
-
/* Adjust by relative CPU power of the group */
sgs->avg_load = (sgs->group_load * SCHED_LOAD_SCALE) / group->cpu_power;
--
1.7.1
next reply other threads:[~2010-07-01 23:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 23:12 Venkatesh Pallipadi [this message]
2010-07-02 8:05 ` Peter Zijlstra
2010-07-02 16:20 ` Venkatesh Pallipadi
2010-07-02 16:40 ` Peter Zijlstra
2010-07-02 16:56 ` Venkatesh Pallipadi
2010-07-02 17:31 ` Peter Zijlstra
2010-07-08 14:12 ` Peter Zijlstra
2010-07-08 17:45 ` Suresh Siddha
2010-07-08 17:49 ` Peter Zijlstra
2010-07-08 17:50 ` Suresh Siddha
2010-07-08 17:55 ` Peter Zijlstra
2010-07-08 18:16 ` Peter Zijlstra
2010-07-08 21:53 ` Suresh Siddha
2010-07-09 13:17 ` Peter Zijlstra
2010-07-17 11:12 ` [tip:sched/core] sched: Update rq->clock for nohz balanced cpus tip-bot for Suresh Siddha
2010-07-12 17:11 ` [PATCH] sched: Call update_group_power only for local_group Venkatesh Pallipadi
2010-07-17 11:12 ` [tip:sched/core] sched: Reduce update_group_power() calls tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278025942-6750-1-git-send-email-venki@google.com \
--to=venki@google.com \
--cc=a.p.zijlstra@chello.nl \
--cc=ego@in.ibm.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®