* [PATCH] cifs: remove unused ip_address field in struct TCP_Server_Info
@ 2010-07-06 12:29 Suresh Jayaraman
2010-07-06 18:22 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: Suresh Jayaraman @ 2010-07-06 12:29 UTC (permalink / raw)
To: Steve French; +Cc: linux-kernel
The ip_address field is not used and seems redundant as there is union addr
already and I don't see any future use as well.
Signed-off-by: Suresh Jayaraman <sjayaraman@suse.de>
---
fs/cifs/cifsglob.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index a88479c..f182fe8 100644
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -142,7 +142,6 @@ struct TCP_Server_Info {
struct list_head pending_mid_q;
void *Server_NlsInfo; /* BB - placeholder for future NLS info */
unsigned short server_codepage; /* codepage for the server */
- unsigned long ip_address; /* IP addr for the server if known */
enum protocolEnum protocolType;
char versionMajor;
char versionMinor;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] cifs: remove unused ip_address field in struct TCP_Server_Info
2010-07-06 12:29 [PATCH] cifs: remove unused ip_address field in struct TCP_Server_Info Suresh Jayaraman
@ 2010-07-06 18:22 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2010-07-06 18:22 UTC (permalink / raw)
To: Suresh Jayaraman; +Cc: linux-kernel
Makes sense - plan to merge this and two others of yours into
cifs-2.6.git today or tomorrow.
On Tue, Jul 6, 2010 at 7:29 AM, Suresh Jayaraman <sjayaraman@suse.de> wrote:
> The ip_address field is not used and seems redundant as there is union addr
> already and I don't see any future use as well.
>
> Signed-off-by: Suresh Jayaraman <sjayaraman@suse.de>
> ---
> fs/cifs/cifsglob.h | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index a88479c..f182fe8 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -142,7 +142,6 @@ struct TCP_Server_Info {
> struct list_head pending_mid_q;
> void *Server_NlsInfo; /* BB - placeholder for future NLS info */
> unsigned short server_codepage; /* codepage for the server */
> - unsigned long ip_address; /* IP addr for the server if known */
> enum protocolEnum protocolType;
> char versionMajor;
> char versionMinor;
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-06 18:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-06 12:29 [PATCH] cifs: remove unused ip_address field in struct TCP_Server_Info Suresh Jayaraman
2010-07-06 18:22 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®