From: Alexander Shishkin <virtuoso@slind.org>
To: linux-kbuild@vger.kernel.org
Cc: "Alexander Shishkin" <virtuoso@slind.org>,
"Sebastian Dalfuß" <sd@sedf.de>,
"Oliver Hartkopp" <oliver@hartkopp.net>,
"Michael Guntsche" <mike@it-loops.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Michael Tokarev" <mjt@tls.msk.ru>, "Alek Du" <alek.du@intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Michal Marek" <mmarek@suse.cz>,
"Russell King" <rmk@arm.linux.org.uk>,
"H. Peter Anvin" <hpa@zytor.com>,
"Albin Tonnerre" <albin.tonnerre@free-electrons.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] [RFC] implement size_append in perl
Date: Wed, 14 Jul 2010 17:01:03 +0300 [thread overview]
Message-ID: <1279116063-4499-1-git-send-email-virtuoso@slind.org> (raw)
The current implementation has been several times fixed to work around
different shells and build environments and it remains a somewhat tricky
shell script. This patch replaces all the dependencies by a single line
of perl. Build dependency on perl is not new, so that shouldn't be a
problem.
The new implementation does exactly what it's supposed to: it outputs
a little-endian 32-bit unsigned integer of a file's length.
This might simplify matters with different build environments and
different shells and is also considerably shorter and hopefully more
readable.
Signed-off-by: Alexander Shishkin <virtuoso@slind.org>
Cc: Sebastian Dalfuß <sd@sedf.de>
Cc: Oliver Hartkopp <oliver@hartkopp.net>
Cc: Michael Guntsche <mike@it-loops.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>
Cc: Alek Du <alek.du@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Marek <mmarek@suse.cz>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Albin Tonnerre <albin.tonnerre@free-electrons.com>
Cc: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
scripts/Makefile.lib | 16 +---------------
1 files changed, 1 insertions(+), 15 deletions(-)
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 54fd1b7..5bfd872 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -213,21 +213,7 @@ cmd_gzip = (cat $(filter-out FORCE,$^) | gzip -f -9 > $@) || \
# Bzip2 and LZMA do not include size in file... so we have to fake that;
# append the size as a 32-bit littleendian number as gzip does.
-size_append = printf $(shell \
-dec_size=0; \
-for F in $1; do \
- fsize=$$(stat -c "%s" $$F); \
- dec_size=$$(expr $$dec_size + $$fsize); \
-done; \
-printf "%08x\n" $$dec_size | \
- sed 's/\(..\)/\1 /g' | { \
- read ch0 ch1 ch2 ch3; \
- for ch in $$ch3 $$ch2 $$ch1 $$ch0; do \
- printf '%s%03o' '\\' $$((0x$$ch)); \
- done; \
- } \
-)
-
+size_append = $(PERL) -e 'print pack("V", (stat "$(lastword $1)")[7])'
quiet_cmd_bzip2 = BZIP2 $@
cmd_bzip2 = (cat $(filter-out FORCE,$^) | \
bzip2 -9 && $(call size_append, $(filter-out FORCE,$^))) > $@ || \
--
1.7.1
next reply other threads:[~2010-07-14 14:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 14:01 Alexander Shishkin [this message]
2010-07-14 14:54 ` H. Peter Anvin
2010-07-14 16:12 ` Alexander Shishkin
2010-07-14 16:33 ` Michal Marek
2010-07-14 15:23 ` Sam Ravnborg
2010-07-14 16:17 ` Alexander Shishkin
2010-07-14 16:57 ` H. Peter Anvin
2010-07-14 20:48 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279116063-4499-1-git-send-email-virtuoso@slind.org \
--to=virtuoso@slind.org \
--cc=akpm@linux-foundation.org \
--cc=albin.tonnerre@free-electrons.com \
--cc=alek.du@intel.com \
--cc=hpa@zytor.com \
--cc=jrnieder@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@it-loops.com \
--cc=mjt@tls.msk.ru \
--cc=mmarek@suse.cz \
--cc=oliver@hartkopp.net \
--cc=rmk@arm.linux.org.uk \
--cc=sd@sedf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®