From: Alexander Shishkin <virtuoso@slind.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kbuild@vger.kernel.org, Sebastian Dalfu? <sd@sedf.de>,
Oliver Hartkopp <oliver@hartkopp.net>,
Michael Guntsche <mike@it-loops.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Michael Tokarev <mjt@tls.msk.ru>, Alek Du <alek.du@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Marek <mmarek@suse.cz>,
Russell King <rmk@arm.linux.org.uk>,
"H. Peter Anvin" <hpa@zytor.com>,
Albin Tonnerre <albin.tonnerre@free-electrons.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] implement size_append in perl
Date: Wed, 14 Jul 2010 19:17:04 +0300 [thread overview]
Message-ID: <20100714161704.GE23436@shisha.kicks-ass.net> (raw)
In-Reply-To: <20100714152337.GA13125@merkur.ravnborg.org>
On Wed, Jul 14, 2010 at 05:23:37 +0200, Sam Ravnborg wrote:
> On Wed, Jul 14, 2010 at 05:01:03PM +0300, Alexander Shishkin wrote:
> > The current implementation has been several times fixed to work around
> > different shells and build environments and it remains a somewhat tricky
> > shell script. This patch replaces all the dependencies by a single line
> > of perl. Build dependency on perl is not new, so that shouldn't be a
> > problem.
> >
> > The new implementation does exactly what it's supposed to: it outputs
> > a little-endian 32-bit unsigned integer of a file's length.
> >
> > This might simplify matters with different build environments and
> > different shells and is also considerably shorter and hopefully more
> > readable.
>
> Reminds me that I had a patch that moved this to mkpiggy.c.
> Goggle gave this hit:
>
> http://lists.openwall.net/linux-kernel/2009/12/20/92
Ok, thanks for the reference.
> I will try to update this to cover arm also and check
> if other archs needs this.
>
> In other word - move thes size stuff to mkpiggy so we
> skip this extra step.
Hm, maybe this mkpiggy can be made arch-independent and moved to scripts/
as well?
Regards,
--
Alex
next prev parent reply other threads:[~2010-07-14 16:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 14:01 Alexander Shishkin
2010-07-14 14:54 ` H. Peter Anvin
2010-07-14 16:12 ` Alexander Shishkin
2010-07-14 16:33 ` Michal Marek
2010-07-14 15:23 ` Sam Ravnborg
2010-07-14 16:17 ` Alexander Shishkin [this message]
2010-07-14 16:57 ` H. Peter Anvin
2010-07-14 20:48 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100714161704.GE23436@shisha.kicks-ass.net \
--to=virtuoso@slind.org \
--cc=akpm@linux-foundation.org \
--cc=albin.tonnerre@free-electrons.com \
--cc=alek.du@intel.com \
--cc=hpa@zytor.com \
--cc=jrnieder@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@it-loops.com \
--cc=mjt@tls.msk.ru \
--cc=mmarek@suse.cz \
--cc=oliver@hartkopp.net \
--cc=rmk@arm.linux.org.uk \
--cc=sam@ravnborg.org \
--cc=sd@sedf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®