* [PATCH 05/11] tulip: formatting of pointers in printk()
@ 2010-07-14 18:02 Kulikov Vasiliy
2010-07-14 22:07 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Kulikov Vasiliy @ 2010-07-14 18:02 UTC (permalink / raw)
To: kernel-janitors
Cc: Grant Grundler, Kyle McMartin, David S. Miller, Joe Perches,
Jiri Pirko, Ben Hutchings, Grant Likely, netdev, linux-kernel,
devicetree-discuss
Use %p instead of %08x in printk().
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/net/tulip/tulip_core.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index 03e96b9..14e5312 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -596,10 +596,10 @@ static void tulip_tx_timeout(struct net_device *dev)
pr_cont(" %02x", buf[j]);
pr_cont(" j=%d\n", j);
}
- printk(KERN_DEBUG " Rx ring %08x: ", (int)tp->rx_ring);
+ printk(KERN_DEBUG " Rx ring %p: ", tp->rx_ring);
for (i = 0; i < RX_RING_SIZE; i++)
pr_cont(" %08x", (unsigned int)tp->rx_ring[i].status);
- printk(KERN_DEBUG " Tx ring %08x: ", (int)tp->tx_ring);
+ printk(KERN_DEBUG " Tx ring %p: ", tp->tx_ring);
for (i = 0; i < TX_RING_SIZE; i++)
pr_cont(" %08x", (unsigned int)tp->tx_ring[i].status);
pr_cont("\n");
--
1.7.0.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 05/11] tulip: formatting of pointers in printk()
2010-07-14 18:02 [PATCH 05/11] tulip: formatting of pointers in printk() Kulikov Vasiliy
@ 2010-07-14 22:07 ` David Miller
2010-07-16 0:46 ` Kyle McMartin
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2010-07-14 22:07 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, grundler, kyle, joe, jpirko, ben, grant.likely,
netdev, linux-kernel, devicetree-discuss
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Wed, 14 Jul 2010 22:02:47 +0400
> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Since patch #5 and #6 are doing the same change to different
files in the same driver, I combined them into one commit.
There is no need to split things up with so much granularity.
If it's all in the same driver, doing the same transformation,
keep it all in one patch.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 05/11] tulip: formatting of pointers in printk()
2010-07-14 22:07 ` David Miller
@ 2010-07-16 0:46 ` Kyle McMartin
0 siblings, 0 replies; 3+ messages in thread
From: Kyle McMartin @ 2010-07-16 0:46 UTC (permalink / raw)
To: David Miller
Cc: segooon, kernel-janitors, grundler, kyle, joe, jpirko, ben,
grant.likely, netdev, linux-kernel, devicetree-discuss
On Wed, Jul 14, 2010 at 03:07:39PM -0700, David Miller wrote:
> Since patch #5 and #6 are doing the same change to different
> files in the same driver, I combined them into one commit.
>
Thanks, Dave!
--Kyle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-16 0:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-14 18:02 [PATCH 05/11] tulip: formatting of pointers in printk() Kulikov Vasiliy
2010-07-14 22:07 ` David Miller
2010-07-16 0:46 ` Kyle McMartin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®