* [PATCH 4/5] tools: perf: fix sign bug
@ 2010-07-17 15:20 Kulikov Vasiliy
0 siblings, 0 replies; only message in thread
From: Kulikov Vasiliy @ 2010-07-17 15:20 UTC (permalink / raw)
To: kernel-janitors
Cc: Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo, Frederic Weisbecker, Masami Hiramatsu,
linux-kernel
'i' is unsigned, so this code is wrong if ext is long enough:
i = strlen(argv[0]) - strlen(ext);
if (i > 0 && !strcmp(argv[0] + i, ext)) { ... }
Make it signed.
The semantic patch that finds this problem (many false-positive results):
(http://coccinelle.lip6.fr/)
// <smpl>
@ r1 @
identifier f;
@@
int f(...) { ... }
@@
identifier r1.f;
type T;
unsigned T x;
@@
*x = f(...)
...
*x > 0
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
tools/perf/perf.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/perf/perf.c b/tools/perf/perf.c
index cdd6c03..cfb857f 100644
--- a/tools/perf/perf.c
+++ b/tools/perf/perf.c
@@ -332,7 +332,7 @@ static void handle_internal_command(int argc, const char **argv)
{ "test", cmd_test, 0 },
{ "inject", cmd_inject, 0 },
};
- unsigned int i;
+ int i;
static const char ext[] = STRIP_EXTENSION;
if (sizeof(ext) > 1) {
--
1.7.0.4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-07-17 15:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-17 15:20 [PATCH 4/5] tools: perf: fix sign bug Kulikov Vasiliy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®