From: Steven Rostedt <rostedt@goodmis.org>
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <trivial@kernel.org>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 29/36] kernel/trace: Remove unnecessary casts of private_data
Date: Thu, 22 Jul 2010 14:58:22 -0400 [thread overview]
Message-ID: <1279825102.3319.15.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <9ba657c52c49f10023a45c178e98acf553a68385.1278967121.git.joe@perches.com>
Late reply due to traveling, but...
On Mon, 2010-07-12 at 13:50 -0700, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> ---
> kernel/trace/ftrace.c | 4 ++--
> kernel/trace/trace.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 0d88ce9..0691e87 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -1592,7 +1592,7 @@ ftrace_failures_open(struct inode *inode, struct file *file)
>
> ret = ftrace_avail_open(inode, file);
> if (!ret) {
> - m = (struct seq_file *)file->private_data;
> + m = file->private_data;
> iter = (struct ftrace_iterator *)m->private;
> iter->flags = FTRACE_ITER_FAILURES;
> }
> @@ -2349,7 +2349,7 @@ static void __init set_ftrace_early_filters(void)
> static int
> ftrace_regex_release(struct inode *inode, struct file *file, int enable)
> {
> - struct seq_file *m = (struct seq_file *)file->private_data;
> + struct seq_file *m = file->private_data;
> struct ftrace_iterator *iter;
> struct trace_parser *parser;
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 8683dec..10b82a1 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2257,7 +2257,7 @@ int tracing_open_generic(struct inode *inode, struct file *filp)
>
> static int tracing_release(struct inode *inode, struct file *file)
> {
> - struct seq_file *m = (struct seq_file *)file->private_data;
> + struct seq_file *m = file->private_data;
> struct trace_iterator *iter;
> int cpu;
>
next prev parent reply other threads:[~2010-07-22 18:58 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 20:49 [PATCH 00/36] " Joe Perches
2010-07-12 20:49 ` [PATCH 01/36] arch/cris: " Joe Perches
2010-07-30 17:24 ` Jesper Nilsson
2010-07-12 20:49 ` [PATCH 02/36] arch/ia64: " Joe Perches
2010-07-12 20:49 ` [PATCH 03/36] arch/powerpc: " Joe Perches
2010-07-12 20:49 ` [PATCH 04/36] arch/s390: " Joe Perches
2010-07-12 20:49 ` [PATCH 05/36] drivers/bluetooth: " Joe Perches
2010-07-12 21:40 ` Marcel Holtmann
2010-07-12 20:49 ` [PATCH 06/36] drivers/char: " Joe Perches
2010-07-12 20:49 ` [PATCH 07/36] drivers/gpu: " Joe Perches
2010-07-12 20:50 ` [PATCH 08/36] drivers/ieee1394: " Joe Perches
2010-07-13 8:25 ` Stefan Richter
2010-07-12 20:50 ` [PATCH 09/36] drivers/infiniband: " Joe Perches
2010-07-13 18:41 ` Ralph Campbell
2010-07-20 15:24 ` Jiri Kosina
2010-07-12 20:50 ` [PATCH 10/36] drivers/isdn: " Joe Perches
2010-07-13 4:13 ` David Miller
2010-07-12 20:50 ` [PATCH 11/36] drivers/media: " Joe Perches
2010-07-12 23:58 ` Jarod Wilson
2010-07-13 8:13 ` Laurent Pinchart
2010-07-12 20:50 ` [PATCH 12/36] drivers/misc: " Joe Perches
2010-07-12 20:50 ` [PATCH 13/36] drivers/net/caif: " Joe Perches
2010-07-13 4:13 ` David Miller
2010-07-12 20:50 ` [PATCH 14/36] drivers/net/wireless: " Joe Perches
2010-07-12 20:50 ` [PATCH 15/36] drivers/s390: " Joe Perches
2010-07-12 20:50 ` [PATCH 16/36] drivers/sbus: " Joe Perches
2010-07-13 4:18 ` David Miller
2010-07-13 5:04 ` Joe Perches
2010-07-12 20:50 ` [PATCH 17/36] drivers/scsi: " Joe Perches
2010-07-12 20:50 ` [PATCH 18/36] drivers/staging: " Joe Perches
2010-07-12 20:50 ` [PATCH 19/36] drivers/usb/gadget: " Joe Perches
2010-07-12 20:50 ` [PATCH 20/36] drivers/usb/misc: " Joe Perches
2010-07-12 20:50 ` [PATCH 21/36] drivers/usb: " Joe Perches
2010-07-12 20:50 ` [PATCH 22/36] fs/cifs: " Joe Perches
2010-07-15 2:41 ` Steve French
2010-07-12 20:50 ` [PATCH 23/36] fs/coda: " Joe Perches
2010-07-12 20:50 ` [PATCH 24/36] fs/ecryptfs: " Joe Perches
2010-07-12 20:50 ` [PATCH 25/36] fs/ext3: " Joe Perches
2010-07-12 20:50 ` [PATCH 26/36] fs/ext4: " Joe Perches
2010-07-23 12:56 ` Ted Ts'o
2010-07-12 20:50 ` [PATCH 27/36] fs/ocfs2: " Joe Perches
2010-07-12 22:37 ` Joel Becker
2010-07-20 15:20 ` Jiri Kosina
2010-07-12 20:50 ` [PATCH 28/36] fs: " Joe Perches
2010-07-12 20:50 ` [PATCH 29/36] kernel/trace: " Joe Perches
2010-07-22 18:58 ` Steven Rostedt [this message]
2010-07-12 20:50 ` [PATCH 30/36] kernel: " Joe Perches
2010-07-12 20:50 ` [PATCH 31/36] net/core: " Joe Perches
2010-07-13 4:14 ` David Miller
2010-07-12 20:50 ` [PATCH 32/36] net/irda: " Joe Perches
2010-07-13 4:14 ` David Miller
2010-07-12 20:50 ` [PATCH 33/36] net/sunrpc: " Joe Perches
2010-07-12 20:50 ` [PATCH 34/36] sound/soc/blackfin: " Joe Perches
2010-07-13 10:45 ` Liam Girdwood
2010-07-13 11:38 ` Mark Brown
2010-07-12 20:50 ` [PATCH 35/36] sound/soc/davinci: " Joe Perches
2010-07-12 20:50 ` [PATCH 36/36] sound/core: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279825102.3319.15.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®