mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jiri Kosina <trivial@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	linux390@de.ibm.com, linux-s390@vger.kernel.org
Subject: [PATCH 15/36] drivers/s390: Remove unnecessary casts of private_data
Date: Mon, 12 Jul 2010 13:50:07 -0700	[thread overview]
Message-ID: <4450e89c24fcd49ba08ea585ab1d145f8ebf1f06.1278967121.git.joe@perches.com> (raw)
In-Reply-To: <cover.1278967120.git.joe@perches.com>

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/s390/block/dasd_eer.c  |    6 +++---
 drivers/s390/char/tape_block.c |    4 ++--
 drivers/s390/char/tape_char.c  |    8 ++++----
 drivers/s390/char/vmcp.c       |    6 +++---
 4 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/s390/block/dasd_eer.c b/drivers/s390/block/dasd_eer.c
index dd88803..75688af 100644
--- a/drivers/s390/block/dasd_eer.c
+++ b/drivers/s390/block/dasd_eer.c
@@ -572,7 +572,7 @@ static int dasd_eer_close(struct inode *inp, struct file *filp)
 	struct eerbuffer *eerb;
 	unsigned long flags;
 
-	eerb = (struct eerbuffer *) filp->private_data;
+	eerb = filp->private_data;
 	spin_lock_irqsave(&bufferlock, flags);
 	list_del(&eerb->list);
 	spin_unlock_irqrestore(&bufferlock, flags);
@@ -591,7 +591,7 @@ static ssize_t dasd_eer_read(struct file *filp, char __user *buf,
         unsigned long flags;
 	struct eerbuffer *eerb;
 
-	eerb = (struct eerbuffer *) filp->private_data;
+	eerb = filp->private_data;
 	if (mutex_lock_interruptible(&readbuffer_mutex))
 		return -ERESTARTSYS;
 
@@ -653,7 +653,7 @@ static unsigned int dasd_eer_poll(struct file *filp, poll_table *ptable)
 	unsigned long flags;
 	struct eerbuffer *eerb;
 
-	eerb = (struct eerbuffer *) filp->private_data;
+	eerb = filp->private_data;
 	poll_wait(filp, &dasd_eer_read_wait_queue, ptable);
 	spin_lock_irqsave(&bufferlock, flags);
 	if (eerb->head != eerb->tail)
diff --git a/drivers/s390/char/tape_block.c b/drivers/s390/char/tape_block.c
index b7de025..d448fe5 100644
--- a/drivers/s390/char/tape_block.c
+++ b/drivers/s390/char/tape_block.c
@@ -296,7 +296,7 @@ tapeblock_revalidate_disk(struct gendisk *disk)
 	unsigned int		nr_of_blks;
 	int			rc;
 
-	device = (struct tape_device *) disk->private_data;
+	device = disk->private_data;
 	BUG_ON(!device);
 
 	if (!device->blk_data.medium_changed)
@@ -345,7 +345,7 @@ tapeblock_medium_changed(struct gendisk *disk)
 {
 	struct tape_device *device;
 
-	device = (struct tape_device *) disk->private_data;
+	device = disk->private_data;
 	DBF_LH(6, "tapeblock_medium_changed(%p) = %d\n",
 		device, device->blk_data.medium_changed);
 
diff --git a/drivers/s390/char/tape_char.c b/drivers/s390/char/tape_char.c
index 539045a..bd037d2 100644
--- a/drivers/s390/char/tape_char.c
+++ b/drivers/s390/char/tape_char.c
@@ -134,7 +134,7 @@ tapechar_read(struct file *filp, char __user *data, size_t count, loff_t *ppos)
 	int rc;
 
 	DBF_EVENT(6, "TCHAR:read\n");
-	device = (struct tape_device *) filp->private_data;
+	device = filp->private_data;
 
 	/*
 	 * If the tape isn't terminated yet, do it now. And since we then
@@ -199,7 +199,7 @@ tapechar_write(struct file *filp, const char __user *data, size_t count, loff_t
 	int i, rc;
 
 	DBF_EVENT(6, "TCHAR:write\n");
-	device = (struct tape_device *) filp->private_data;
+	device = filp->private_data;
 	/* Find out block size and number of blocks */
 	if (device->char_data.block_size != 0) {
 		if (count < device->char_data.block_size) {
@@ -317,7 +317,7 @@ tapechar_release(struct inode *inode, struct file *filp)
 	struct tape_device *device;
 
 	DBF_EVENT(6, "TCHAR:release: %x\n", iminor(inode));
-	device = (struct tape_device *) filp->private_data;
+	device = filp->private_data;
 
 	/*
 	 * If this is the rewinding tape minor then rewind. In that case we
@@ -454,7 +454,7 @@ tapechar_ioctl(struct file *filp, unsigned int no, unsigned long data)
 
 	DBF_EVENT(6, "TCHAR:ioct\n");
 
-	device = (struct tape_device *) filp->private_data;
+	device = filp->private_data;
 	mutex_lock(&device->mutex);
 	rc = __tapechar_ioctl(device, no, data);
 	mutex_unlock(&device->mutex);
diff --git a/drivers/s390/char/vmcp.c b/drivers/s390/char/vmcp.c
index 04e532e..19a14d9 100644
--- a/drivers/s390/char/vmcp.c
+++ b/drivers/s390/char/vmcp.c
@@ -47,7 +47,7 @@ static int vmcp_release(struct inode *inode, struct file *file)
 {
 	struct vmcp_session *session;
 
-	session = (struct vmcp_session *)file->private_data;
+	session = file->private_data;
 	file->private_data = NULL;
 	free_pages((unsigned long)session->response, get_order(session->bufsize));
 	kfree(session);
@@ -94,7 +94,7 @@ vmcp_write(struct file *file, const char __user *buff, size_t count,
 		return -EFAULT;
 	}
 	cmd[count] = '\0';
-	session = (struct vmcp_session *)file->private_data;
+	session = file->private_data;
 	if (mutex_lock_interruptible(&session->mutex)) {
 		kfree(cmd);
 		return -ERESTARTSYS;
@@ -136,7 +136,7 @@ static long vmcp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 	int __user *argp;
 	int temp;
 
-	session = (struct vmcp_session *)file->private_data;
+	session = file->private_data;
 	if (is_compat_task())
 		argp = compat_ptr(arg);
 	else
-- 
1.7.1.337.g6068.dirty


  parent reply	other threads:[~2010-07-12 20:50 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-12 20:49 [PATCH 00/36] " Joe Perches
2010-07-12 20:49 ` [PATCH 01/36] arch/cris: " Joe Perches
2010-07-30 17:24   ` Jesper Nilsson
2010-07-12 20:49 ` [PATCH 02/36] arch/ia64: " Joe Perches
2010-07-12 20:49 ` [PATCH 03/36] arch/powerpc: " Joe Perches
2010-07-12 20:49 ` [PATCH 04/36] arch/s390: " Joe Perches
2010-07-12 20:49 ` [PATCH 05/36] drivers/bluetooth: " Joe Perches
2010-07-12 21:40   ` Marcel Holtmann
2010-07-12 20:49 ` [PATCH 06/36] drivers/char: " Joe Perches
2010-07-12 20:49 ` [PATCH 07/36] drivers/gpu: " Joe Perches
2010-07-12 20:50 ` [PATCH 08/36] drivers/ieee1394: " Joe Perches
2010-07-13  8:25   ` Stefan Richter
2010-07-12 20:50 ` [PATCH 09/36] drivers/infiniband: " Joe Perches
2010-07-13 18:41   ` Ralph Campbell
2010-07-20 15:24     ` Jiri Kosina
2010-07-12 20:50 ` [PATCH 10/36] drivers/isdn: " Joe Perches
2010-07-13  4:13   ` David Miller
2010-07-12 20:50 ` [PATCH 11/36] drivers/media: " Joe Perches
2010-07-12 23:58   ` Jarod Wilson
2010-07-13  8:13   ` Laurent Pinchart
2010-07-12 20:50 ` [PATCH 12/36] drivers/misc: " Joe Perches
2010-07-12 20:50 ` [PATCH 13/36] drivers/net/caif: " Joe Perches
2010-07-13  4:13   ` David Miller
2010-07-12 20:50 ` [PATCH 14/36] drivers/net/wireless: " Joe Perches
2010-07-12 20:50 ` Joe Perches [this message]
2010-07-12 20:50 ` [PATCH 16/36] drivers/sbus: " Joe Perches
2010-07-13  4:18   ` David Miller
2010-07-13  5:04     ` Joe Perches
2010-07-12 20:50 ` [PATCH 17/36] drivers/scsi: " Joe Perches
2010-07-12 20:50 ` [PATCH 18/36] drivers/staging: " Joe Perches
2010-07-12 20:50 ` [PATCH 19/36] drivers/usb/gadget: " Joe Perches
2010-07-12 20:50 ` [PATCH 20/36] drivers/usb/misc: " Joe Perches
2010-07-12 20:50 ` [PATCH 21/36] drivers/usb: " Joe Perches
2010-07-12 20:50 ` [PATCH 22/36] fs/cifs: " Joe Perches
2010-07-15  2:41   ` Steve French
2010-07-12 20:50 ` [PATCH 23/36] fs/coda: " Joe Perches
2010-07-12 20:50 ` [PATCH 24/36] fs/ecryptfs: " Joe Perches
2010-07-12 20:50 ` [PATCH 25/36] fs/ext3: " Joe Perches
2010-07-12 20:50 ` [PATCH 26/36] fs/ext4: " Joe Perches
2010-07-23 12:56   ` Ted Ts'o
2010-07-12 20:50 ` [PATCH 27/36] fs/ocfs2: " Joe Perches
2010-07-12 22:37   ` Joel Becker
2010-07-20 15:20     ` Jiri Kosina
2010-07-12 20:50 ` [PATCH 28/36] fs: " Joe Perches
2010-07-12 20:50 ` [PATCH 29/36] kernel/trace: " Joe Perches
2010-07-22 18:58   ` Steven Rostedt
2010-07-12 20:50 ` [PATCH 30/36] kernel: " Joe Perches
2010-07-12 20:50 ` [PATCH 31/36] net/core: " Joe Perches
2010-07-13  4:14   ` David Miller
2010-07-12 20:50 ` [PATCH 32/36] net/irda: " Joe Perches
2010-07-13  4:14   ` David Miller
2010-07-12 20:50 ` [PATCH 33/36] net/sunrpc: " Joe Perches
2010-07-12 20:50 ` [PATCH 34/36] sound/soc/blackfin: " Joe Perches
2010-07-13 10:45   ` Liam Girdwood
2010-07-13 11:38   ` Mark Brown
2010-07-12 20:50 ` [PATCH 35/36] sound/soc/davinci: " Joe Perches
2010-07-12 20:50 ` [PATCH 36/36] sound/core: " Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4450e89c24fcd49ba08ea585ab1d145f8ebf1f06.1278967121.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux390@de.ibm.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®