From: Ernesto Ramos <ernesto@ti.com>
To: gregkh@suse.de
Cc: omar.ramirez@ti.com, ohad@wizery.com, ameya.palande@nokia.com,
felipe.contreras@nokia.com, fernando.lugo@ti.com,
linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com,
nm@ti.com, linux-omap@vger.kernel.org,
Ernesto Ramos <ernesto@ti.com>
Subject: [PATCH 09/10] staging:ti dspbridge: remove DSP_FAILED macro from services
Date: Wed, 28 Jul 2010 09:45:32 -0500 [thread overview]
Message-ID: <1280328333-31336-10-git-send-email-ernesto@ti.com> (raw)
In-Reply-To: <1280328333-31336-9-git-send-email-ernesto@ti.com>
Since status succeeded is 0, DSP_FAILED macro
is not necessary anymore.
Signed-off-by: Ernesto Ramos <ernesto@ti.com>
---
drivers/staging/tidspbridge/services/cfg.c | 13 ++++++-------
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/tidspbridge/services/cfg.c b/drivers/staging/tidspbridge/services/cfg.c
index c3f33f6..a7af74f 100644
--- a/drivers/staging/tidspbridge/services/cfg.c
+++ b/drivers/staging/tidspbridge/services/cfg.c
@@ -102,7 +102,7 @@ int cfg_get_dev_object(struct cfg_devnode *dev_node_obj,
"TIOMAP1510")))
*value = (u32)drv_datap->dev_object;
}
- if (DSP_FAILED(status))
+ if (status)
pr_err("%s: Failed, status 0x%x\n", __func__, status);
return status;
}
@@ -130,7 +130,7 @@ int cfg_get_exec_file(struct cfg_devnode *dev_node_obj, u32 buf_size,
if (!status && drv_datap->base_img)
strcpy(str_exec_file, drv_datap->base_img);
- if (DSP_FAILED(status))
+ if (status)
pr_err("%s: Failed, status 0x%x\n", __func__, status);
DBC_ENSURE(((status == 0) &&
(strlen(str_exec_file) <= buf_size))
@@ -174,12 +174,11 @@ int cfg_get_object(u32 *value, u8 dw_type)
default:
break;
}
- if (DSP_FAILED(status)) {
+ if (status) {
*value = 0;
pr_err("%s: Failed, status 0x%x\n", __func__, status);
}
- DBC_ENSURE((!status && *value != 0) ||
- (DSP_FAILED(status) && *value == 0));
+ DBC_ENSURE((!status && *value != 0) || (status && *value == 0));
return status;
}
@@ -217,7 +216,7 @@ int cfg_set_dev_object(struct cfg_devnode *dev_node_obj, u32 value)
if (!(strcmp((char *)dev_node_obj, "TIOMAP1510")))
drv_datap->dev_object = (void *) value;
}
- if (DSP_FAILED(status))
+ if (status)
pr_err("%s: Failed, status 0x%x\n", __func__, status);
return status;
@@ -248,7 +247,7 @@ int cfg_set_object(u32 value, u8 dw_type)
default:
break;
}
- if (DSP_FAILED(status))
+ if (status)
pr_err("%s: Failed, status 0x%x\n", __func__, status);
return status;
}
--
1.5.4.5
next prev parent reply other threads:[~2010-07-28 14:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 14:45 [PATCH 00/10] staging:ti dspbridge: Remove DSP_FAILED and DSP_SUCCEEDED macros Ernesto Ramos
2010-07-28 14:45 ` [PATCH 01/10] staging:ti dspbridge: remove DSP_SUCCEEDED macro from core Ernesto Ramos
2010-07-28 14:45 ` [PATCH 02/10] staging:ti dspbridge: remove DSP_SUCCEEDED macro from pmgr Ernesto Ramos
2010-07-28 14:45 ` [PATCH 03/10] staging:ti dspbridge: remove DSP_SUCCEEDED macro from rmgr Ernesto Ramos
2010-07-28 14:45 ` [PATCH 04/10] staging:ti dspbridge: remove DSP_SUCCEEDED macro from services Ernesto Ramos
2010-07-28 14:45 ` [PATCH 05/10] staging:ti dspbridge: remove DSP_SUCCEEDED macro definition Ernesto Ramos
2010-07-28 14:45 ` [PATCH 06/10] staging:ti dspbridge: remove DSP_FAILED macro from core Ernesto Ramos
2010-07-28 14:45 ` [PATCH 07/10] staging:ti dspbridge: remove DSP_FAILED macro from pmgr Ernesto Ramos
2010-07-28 14:45 ` [PATCH 08/10] staging:ti dspbridge: remove DSP_FAILED macro from rmgr Ernesto Ramos
2010-07-28 14:45 ` Ernesto Ramos [this message]
2010-07-28 14:45 ` [PATCH 10/10] staging:ti dspbridge: remove DSP_FAILED macro definition Ernesto Ramos
2010-07-30 15:16 ` [PATCH 00/10] staging:ti dspbridge: Remove DSP_FAILED and DSP_SUCCEEDED macros Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280328333-31336-10-git-send-email-ernesto@ti.com \
--to=ernesto@ti.com \
--cc=ameya.palande@nokia.com \
--cc=andy.shevchenko@gmail.com \
--cc=felipe.contreras@nokia.com \
--cc=fernando.lugo@ti.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=ohad@wizery.com \
--cc=omar.ramirez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®