From: Ernesto Ramos <ernesto@ti.com>
To: gregkh@suse.de
Cc: omar.ramirez@ti.com, ohad@wizery.com, ameya.palande@nokia.com,
felipe.contreras@nokia.com, fernando.lugo@ti.com,
linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com,
nm@ti.com, linux-omap@vger.kernel.org,
Ernesto Ramos <ernesto@ti.com>
Subject: [PATCH 04/10] staging:ti dspbridge: remove DSP_SUCCEEDED macro from services
Date: Wed, 28 Jul 2010 09:45:27 -0500 [thread overview]
Message-ID: <1280328333-31336-5-git-send-email-ernesto@ti.com> (raw)
In-Reply-To: <1280328333-31336-4-git-send-email-ernesto@ti.com>
Since status succeeded is now 0 macro DSP_SUCCEEDED
is not necessary anymore.
Signed-off-by: Ernesto Ramos <ernesto@ti.com>
---
drivers/staging/tidspbridge/services/cfg.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/tidspbridge/services/cfg.c b/drivers/staging/tidspbridge/services/cfg.c
index 4ab3cd7..c3f33f6 100644
--- a/drivers/staging/tidspbridge/services/cfg.c
+++ b/drivers/staging/tidspbridge/services/cfg.c
@@ -62,7 +62,7 @@ int cfg_get_auto_start(struct cfg_devnode *dev_node_obj,
status = -EFAULT;
if (!auto_start || !drv_datap)
status = -EFAULT;
- if (DSP_SUCCEEDED(status))
+ if (!status)
*auto_start = (drv_datap->base_img) ? 1 : 0;
DBC_ENSURE((status == 0 &&
@@ -93,7 +93,7 @@ int cfg_get_dev_object(struct cfg_devnode *dev_node_obj,
status = -EFAULT;
dw_buf_size = sizeof(value);
- if (DSP_SUCCEEDED(status)) {
+ if (!status) {
/* check the device string and then store dev object */
if (!
@@ -127,7 +127,7 @@ int cfg_get_exec_file(struct cfg_devnode *dev_node_obj, u32 buf_size,
if (strlen(drv_datap->base_img) > buf_size)
status = -EINVAL;
- if (DSP_SUCCEEDED(status) && drv_datap->base_img)
+ if (!status && drv_datap->base_img)
strcpy(str_exec_file, drv_datap->base_img);
if (DSP_FAILED(status))
@@ -178,7 +178,7 @@ int cfg_get_object(u32 *value, u8 dw_type)
*value = 0;
pr_err("%s: Failed, status 0x%x\n", __func__, status);
}
- DBC_ENSURE((DSP_SUCCEEDED(status) && *value != 0) ||
+ DBC_ENSURE((!status && *value != 0) ||
(DSP_FAILED(status) && *value == 0));
return status;
}
@@ -211,7 +211,7 @@ int cfg_set_dev_object(struct cfg_devnode *dev_node_obj, u32 value)
if (!dev_node_obj)
status = -EFAULT;
- if (DSP_SUCCEEDED(status)) {
+ if (!status) {
/* Store the Bridge device object in the Registry */
if (!(strcmp((char *)dev_node_obj, "TIOMAP1510")))
--
1.5.4.5
next prev parent reply other threads:[~2010-07-28 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 14:45 [PATCH 00/10] staging:ti dspbridge: Remove DSP_FAILED and DSP_SUCCEEDED macros Ernesto Ramos
2010-07-28 14:45 ` [PATCH 01/10] staging:ti dspbridge: remove DSP_SUCCEEDED macro from core Ernesto Ramos
2010-07-28 14:45 ` [PATCH 02/10] staging:ti dspbridge: remove DSP_SUCCEEDED macro from pmgr Ernesto Ramos
2010-07-28 14:45 ` [PATCH 03/10] staging:ti dspbridge: remove DSP_SUCCEEDED macro from rmgr Ernesto Ramos
2010-07-28 14:45 ` Ernesto Ramos [this message]
2010-07-28 14:45 ` [PATCH 05/10] staging:ti dspbridge: remove DSP_SUCCEEDED macro definition Ernesto Ramos
2010-07-28 14:45 ` [PATCH 06/10] staging:ti dspbridge: remove DSP_FAILED macro from core Ernesto Ramos
2010-07-28 14:45 ` [PATCH 07/10] staging:ti dspbridge: remove DSP_FAILED macro from pmgr Ernesto Ramos
2010-07-28 14:45 ` [PATCH 08/10] staging:ti dspbridge: remove DSP_FAILED macro from rmgr Ernesto Ramos
2010-07-28 14:45 ` [PATCH 09/10] staging:ti dspbridge: remove DSP_FAILED macro from services Ernesto Ramos
2010-07-28 14:45 ` [PATCH 10/10] staging:ti dspbridge: remove DSP_FAILED macro definition Ernesto Ramos
2010-07-30 15:16 ` [PATCH 00/10] staging:ti dspbridge: Remove DSP_FAILED and DSP_SUCCEEDED macros Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280328333-31336-5-git-send-email-ernesto@ti.com \
--to=ernesto@ti.com \
--cc=ameya.palande@nokia.com \
--cc=andy.shevchenko@gmail.com \
--cc=felipe.contreras@nokia.com \
--cc=fernando.lugo@ti.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=ohad@wizery.com \
--cc=omar.ramirez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®