mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] block: move blk_register_queue() before uevent is send out
@ 2010-07-30  8:59 Kay Sievers
  0 siblings, 0 replies; only message in thread
From: Kay Sievers @ 2010-07-30  8:59 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-kernel, Karel Zak

From: Kay Sievers <kay.sievers@vrfy.org>
Subject: block: move blk_register_queue() before uevent is send out

Sysfs attributes should be created before the device is announced to
userspace. Createing attributes after the event makes it impossible
to use them reliably from udev.

The issue was found by Karel.

Cc: Karel Zak <kzak@redhat.com>
Signed-Off-By: Kay Sievers <kay.sievers@vrfy.org>
---
 block/genhd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/block/genhd.c
+++ b/block/genhd.c
@@ -531,6 +531,7 @@ static void register_disk(struct gendisk
 #endif
 	disk->part0.holder_dir = kobject_create_and_add("holders", &ddev->kobj);
 	disk->slave_dir = kobject_create_and_add("slaves", &ddev->kobj);
+	blk_register_queue(disk);
 
 	/* No minors to use for partitions */
 	if (!disk_partitionable(disk))
@@ -602,7 +603,6 @@ void add_disk(struct gendisk *disk)
 	blk_register_region(disk_devt(disk), disk->minors, NULL,
 			    exact_match, exact_lock, disk);
 	register_disk(disk);
-	blk_register_queue(disk);
 
 	bdi = &disk->queue->backing_dev_info;
 	bdi_register_dev(bdi, disk_devt(disk));



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-07-30  8:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-30  8:59 [PATCH] block: move blk_register_queue() before uevent is send out Kay Sievers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®