From: Jason Wessel <jason.wessel@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: kgdb-bugreport@lists.sourceforge.net, mingo@elte.hu,
Jason Wessel <jason.wessel@windriver.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 12/15] ftrace,kdb: Allow dumping a specific cpu's buffer with ftdump
Date: Fri, 30 Jul 2010 14:17:33 -0500 [thread overview]
Message-ID: <1280517456-1167-13-git-send-email-jason.wessel@windriver.com> (raw)
In-Reply-To: <1280517456-1167-1-git-send-email-jason.wessel@windriver.com>
In systems with more than one processor it is desirable to look at the
per cpu trace buffers.
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
CC: Frederic Weisbecker <fweisbec@gmail.com>
---
kernel/trace/trace_kdb.c | 37 +++++++++++++++++++++++++++----------
1 files changed, 27 insertions(+), 10 deletions(-)
diff --git a/kernel/trace/trace_kdb.c b/kernel/trace/trace_kdb.c
index 44cbda2..7b8ecd7 100644
--- a/kernel/trace/trace_kdb.c
+++ b/kernel/trace/trace_kdb.c
@@ -17,7 +17,7 @@
#include "trace.h"
#include "trace_output.h"
-static void ftrace_dump_buf(int skip_lines)
+static void ftrace_dump_buf(int skip_lines, long cpu_file)
{
/* use static because iter can be a bit big for the stack */
static struct trace_iterator iter;
@@ -44,13 +44,20 @@ static void ftrace_dump_buf(int skip_lines)
iter.iter_flags |= TRACE_FILE_LAT_FMT;
iter.pos = -1;
- for_each_tracing_cpu(cpu) {
- iter.buffer_iter[cpu] =
+ if (cpu_file == TRACE_PIPE_ALL_CPU) {
+ for_each_tracing_cpu(cpu) {
+ iter.buffer_iter[cpu] =
ring_buffer_read_prepare(iter.tr->buffer, cpu);
- ring_buffer_read_start(iter.buffer_iter[cpu]);
- tracing_iter_reset(&iter, cpu);
+ ring_buffer_read_start(iter.buffer_iter[cpu]);
+ tracing_iter_reset(&iter, cpu);
+ }
+ } else {
+ iter.cpu_file = cpu_file;
+ iter.buffer_iter[cpu_file] =
+ ring_buffer_read_prepare(iter.tr->buffer, cpu_file);
+ ring_buffer_read_start(iter.buffer_iter[cpu_file]);
+ tracing_iter_reset(&iter, cpu_file);
}
-
if (!trace_empty(&iter))
trace_find_next_entry_inc(&iter);
while (!trace_empty(&iter)) {
@@ -91,9 +98,10 @@ out:
static int kdb_ftdump(int argc, const char **argv)
{
int skip_lines = 0;
+ long cpu_file;
char *cp;
- if (argc > 1)
+ if (argc > 2)
return KDB_ARGCOUNT;
if (argc) {
@@ -102,8 +110,17 @@ static int kdb_ftdump(int argc, const char **argv)
skip_lines = 0;
}
+ if (argc == 2) {
+ cpu_file = simple_strtol(argv[2], &cp, 0);
+ if (*cp || cpu_file >= NR_CPUS || cpu_file < 0 ||
+ !cpu_online(cpu_file))
+ return KDB_BADINT;
+ } else {
+ cpu_file = TRACE_PIPE_ALL_CPU;
+ }
+
kdb_trap_printk++;
- ftrace_dump_buf(skip_lines);
+ ftrace_dump_buf(skip_lines, cpu_file);
kdb_trap_printk--;
return 0;
@@ -111,8 +128,8 @@ static int kdb_ftdump(int argc, const char **argv)
static __init int kdb_ftrace_register(void)
{
- kdb_register_repeat("ftdump", kdb_ftdump, "", "Dump ftrace log",
- 0, KDB_REPEAT_NONE);
+ kdb_register_repeat("ftdump", kdb_ftdump, "[skip_#lines] [cpu]",
+ "Dump ftrace log", 0, KDB_REPEAT_NONE);
return 0;
}
--
1.6.4.rc1
next prev parent reply other threads:[~2010-07-30 19:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 19:17 [PATCH 0/15] kgdb,kdb: proposed merge set for 2.6.36 Jason Wessel
2010-07-30 19:17 ` [PATCH 01/15] kgdb: remove custom hex_to_bin()implementation Jason Wessel
2010-07-30 19:17 ` [PATCH 02/15] gdbstub: Optimize kgdb's "thread:" response for the gdb serial protocol Jason Wessel
2010-07-30 19:17 ` [PATCH 03/15] kgdb,kdb: individual register set and and get API Jason Wessel
2010-07-30 19:17 ` [PATCH 04/15] x86,kgdb: Individual register get/set for x86 Jason Wessel
2010-07-30 23:29 ` H. Peter Anvin
2010-07-30 19:17 ` [PATCH 05/15] mips,kgdb: Individual register get/set for mips Jason Wessel
2010-08-02 13:30 ` Ralf Baechle
2010-07-30 19:17 ` [PATCH 06/15] arm,kgdb: Individual register get/set for arm Jason Wessel
2010-07-30 19:17 ` [PATCH 07/15] gdbstub,x86: Implement gdbserial 'p' and 'P' packets Jason Wessel
2010-07-30 19:17 ` [PATCH 08/15] gdbstub: do not directly use dbg_reg_def[] in gdb_cmd_reg_set() Jason Wessel
2010-07-30 19:17 ` [PATCH 09/15] arm,kgdb: Add ability to trap into debugger on notify_die Jason Wessel
2010-07-30 19:17 ` [PATCH 10/15] powerpc: Replace hardcoded offset by BREAK_INSTR_SIZE Jason Wessel
2010-07-30 23:44 ` Benjamin Herrenschmidt
2010-07-30 19:17 ` [PATCH 11/15] ftrace,kdb: Extend kdb to be able to dump the ftrace buffer Jason Wessel
2010-07-30 19:17 ` Jason Wessel [this message]
2010-07-30 19:17 ` [PATCH 13/15] KGDB: Remove set but unused newPC Jason Wessel
2010-07-30 19:17 ` [PATCH 14/15] sunhv,kgdboc: Add sunhv console poll hooks for kgdboc Jason Wessel
2010-07-30 19:17 ` [PATCH 15/15] mm,kdb,kgdb: Add a debug reference for the kdb kmap usage Jason Wessel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280517456-1167-13-git-send-email-jason.wessel@windriver.com \
--to=jason.wessel@windriver.com \
--cc=fweisbec@gmail.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®