mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: kgdb-bugreport@lists.sourceforge.net, mingo@elte.hu,
	Andy Shevchenko <ext-andriy.shevchenko@nokia.com>,
	Jason Wessel <jason.wessel@windriver.com>
Subject: [PATCH 01/15] kgdb: remove custom hex_to_bin()implementation
Date: Fri, 30 Jul 2010 14:17:22 -0500	[thread overview]
Message-ID: <1280517456-1167-2-git-send-email-jason.wessel@windriver.com> (raw)
In-Reply-To: <1280517456-1167-1-git-send-email-jason.wessel@windriver.com>

From: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>

Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
 kernel/debug/gdbstub.c |   21 +++++----------------
 1 files changed, 5 insertions(+), 16 deletions(-)

diff --git a/kernel/debug/gdbstub.c b/kernel/debug/gdbstub.c
index e8fd686..3517fd7 100644
--- a/kernel/debug/gdbstub.c
+++ b/kernel/debug/gdbstub.c
@@ -52,17 +52,6 @@ static unsigned long		gdb_regs[(NUMREGBYTES +
  * GDB remote protocol parser:
  */
 
-static int hex(char ch)
-{
-	if ((ch >= 'a') && (ch <= 'f'))
-		return ch - 'a' + 10;
-	if ((ch >= '0') && (ch <= '9'))
-		return ch - '0';
-	if ((ch >= 'A') && (ch <= 'F'))
-		return ch - 'A' + 10;
-	return -1;
-}
-
 #ifdef CONFIG_KGDB_KDB
 static int gdbstub_read_wait(void)
 {
@@ -123,8 +112,8 @@ static void get_packet(char *buffer)
 		buffer[count] = 0;
 
 		if (ch == '#') {
-			xmitcsum = hex(gdbstub_read_wait()) << 4;
-			xmitcsum += hex(gdbstub_read_wait());
+			xmitcsum = hex_to_bin(gdbstub_read_wait()) << 4;
+			xmitcsum += hex_to_bin(gdbstub_read_wait());
 
 			if (checksum != xmitcsum)
 				/* failed checksum */
@@ -280,8 +269,8 @@ int kgdb_hex2mem(char *buf, char *mem, int count)
 	tmp_hex = tmp_raw - 1;
 	while (tmp_hex >= buf) {
 		tmp_raw--;
-		*tmp_raw = hex(*tmp_hex--);
-		*tmp_raw |= hex(*tmp_hex--) << 4;
+		*tmp_raw = hex_to_bin(*tmp_hex--);
+		*tmp_raw |= hex_to_bin(*tmp_hex--) << 4;
 	}
 
 	return probe_kernel_write(mem, tmp_raw, count);
@@ -304,7 +293,7 @@ int kgdb_hex2long(char **ptr, unsigned long *long_val)
 		(*ptr)++;
 	}
 	while (**ptr) {
-		hex_val = hex(**ptr);
+		hex_val = hex_to_bin(**ptr);
 		if (hex_val < 0)
 			break;
 
-- 
1.6.4.rc1


  reply	other threads:[~2010-07-30 19:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-30 19:17 [PATCH 0/15] kgdb,kdb: proposed merge set for 2.6.36 Jason Wessel
2010-07-30 19:17 ` Jason Wessel [this message]
2010-07-30 19:17 ` [PATCH 02/15] gdbstub: Optimize kgdb's "thread:" response for the gdb serial protocol Jason Wessel
2010-07-30 19:17 ` [PATCH 03/15] kgdb,kdb: individual register set and and get API Jason Wessel
2010-07-30 19:17 ` [PATCH 04/15] x86,kgdb: Individual register get/set for x86 Jason Wessel
2010-07-30 23:29   ` H. Peter Anvin
2010-07-30 19:17 ` [PATCH 05/15] mips,kgdb: Individual register get/set for mips Jason Wessel
2010-08-02 13:30   ` Ralf Baechle
2010-07-30 19:17 ` [PATCH 06/15] arm,kgdb: Individual register get/set for arm Jason Wessel
2010-07-30 19:17 ` [PATCH 07/15] gdbstub,x86: Implement gdbserial 'p' and 'P' packets Jason Wessel
2010-07-30 19:17 ` [PATCH 08/15] gdbstub: do not directly use dbg_reg_def[] in gdb_cmd_reg_set() Jason Wessel
2010-07-30 19:17 ` [PATCH 09/15] arm,kgdb: Add ability to trap into debugger on notify_die Jason Wessel
2010-07-30 19:17 ` [PATCH 10/15] powerpc: Replace hardcoded offset by BREAK_INSTR_SIZE Jason Wessel
2010-07-30 23:44   ` Benjamin Herrenschmidt
2010-07-30 19:17 ` [PATCH 11/15] ftrace,kdb: Extend kdb to be able to dump the ftrace buffer Jason Wessel
2010-07-30 19:17 ` [PATCH 12/15] ftrace,kdb: Allow dumping a specific cpu's buffer with ftdump Jason Wessel
2010-07-30 19:17 ` [PATCH 13/15] KGDB: Remove set but unused newPC Jason Wessel
2010-07-30 19:17 ` [PATCH 14/15] sunhv,kgdboc: Add sunhv console poll hooks for kgdboc Jason Wessel
2010-07-30 19:17 ` [PATCH 15/15] mm,kdb,kgdb: Add a debug reference for the kdb kmap usage Jason Wessel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280517456-1167-2-git-send-email-jason.wessel@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=ext-andriy.shevchenko@nokia.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®