mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [GIT PULL] kgdboc compile fix
@ 2010-08-06 20:43 Jason Wessel
  2010-08-06 20:43 ` [PATCH 1/1] console: Fix compilation regression Jason Wessel
  0 siblings, 1 reply; 2+ messages in thread
From: Jason Wessel @ 2010-08-06 20:43 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel, kgdb-bugreport, Jesse Barnes

Linus, please pull the for_linus which contains a compilation fix for
building without the kernel config option CONFIG_HW_CONSOLE.

git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdb.git for_lin
us

There are some other fixes brewing, but this is the only known
compilation problem and I know we would like to keep the tree fully
bisectable.

Thanks,
Jason.

---
Jason Wessel (1):
      console: Fix compilation regression

 include/linux/console.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] console: Fix compilation regression
  2010-08-06 20:43 [GIT PULL] kgdboc compile fix Jason Wessel
@ 2010-08-06 20:43 ` Jason Wessel
  0 siblings, 0 replies; 2+ messages in thread
From: Jason Wessel @ 2010-08-06 20:43 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel, kgdb-bugreport, Jesse Barnes, Jason Wessel

A regression of building without CONFIG_HW_CONSOLE was introduced with
commit b45cfba4e9005d64d419718e7ff7f7cab44c1994 (vt,console,kdb:
implement atomic console enter/leave functions).

ERROR: "con_debug_enter" [drivers/serial/kgdboc.ko] undefined!
ERROR: "vc_cons" [drivers/serial/kgdboc.ko] undefined!
ERROR: "fg_console" [drivers/serial/kgdboc.ko] undefined!
ERROR: "con_debug_leave" [drivers/serial/kgdboc.ko] undefined!

When there is no HW console the con_debug_enter and con_debug_leave
functions should have no code.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
CC: Jesse Barnes <jbarnes@virtuousgeek.org>
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>

---
 include/linux/console.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/include/linux/console.h b/include/linux/console.h
index f76fc29..95cf6f0 100644
--- a/include/linux/console.h
+++ b/include/linux/console.h
@@ -79,8 +79,13 @@ int register_con_driver(const struct consw *csw, int first, int last);
 int unregister_con_driver(const struct consw *csw);
 int take_over_console(const struct consw *sw, int first, int last, int deflt);
 void give_up_console(const struct consw *sw);
+#ifdef CONFIG_HW_CONSOLE
 int con_debug_enter(struct vc_data *vc);
 int con_debug_leave(void);
+#else
+#define con_debug_enter(vc) (0)
+#define con_debug_leave() (0)
+#endif
 
 /* scroll */
 #define SM_UP       (1)
-- 
1.6.3.3


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-08-06 20:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-06 20:43 [GIT PULL] kgdboc compile fix Jason Wessel
2010-08-06 20:43 ` [PATCH 1/1] console: Fix compilation regression Jason Wessel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®