From: Vivek Goyal <vgoyal@redhat.com>
To: linux-kernel@vger.kernel.org, jaxboe@fusionio.com
Cc: vgoyal@redhat.com
Subject: [PATCH 1/5] cfq-iosched: Do not idle if slice_idle=0
Date: Wed, 11 Aug 2010 18:44:23 -0400 [thread overview]
Message-ID: <1281566667-7821-2-git-send-email-vgoyal@redhat.com> (raw)
In-Reply-To: <1281566667-7821-1-git-send-email-vgoyal@redhat.com>
o do not idle either on cfq queue or service tree if slice_idle=0. User does
not want any queue or service tree idling. Currently even if slice_idle=0,
we were waiting for request to finish before expiring the queue and that
can lead to lower queue depths.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
block/cfq-iosched.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index eb4086f..8830569 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -1839,6 +1839,9 @@ static bool cfq_should_idle(struct cfq_data *cfqd, struct cfq_queue *cfqq)
BUG_ON(!service_tree);
BUG_ON(!service_tree->count);
+ if (!cfqd->cfq_slice_idle)
+ return false;
+
/* We never do for idle class queues. */
if (prio == IDLE_WORKLOAD)
return false;
@@ -1879,7 +1882,7 @@ static void cfq_arm_slice_timer(struct cfq_data *cfqd)
/*
* idle is disabled, either manually or by past process history
*/
- if (!cfqd->cfq_slice_idle || !cfq_should_idle(cfqd, cfqq))
+ if (!cfq_should_idle(cfqd, cfqq))
return;
/*
--
1.7.1.1
next prev parent reply other threads:[~2010-08-11 22:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 22:44 [PATCH] cfq-iosched: cfq-iosched: Implement group idling and IOPS accounting for groups V4 Vivek Goyal
2010-08-11 22:44 ` Vivek Goyal [this message]
2010-08-16 18:37 ` [PATCH 1/5] cfq-iosched: Do not idle if slice_idle=0 Jeff Moyer
2010-08-11 22:44 ` [PATCH 2/5] cfq-iosched: Do group share accounting in IOPS when slice_idle=0 Vivek Goyal
2010-08-16 18:45 ` Jeff Moyer
2010-08-11 22:44 ` [PATCH 3/5] cfq-iosched: Implement tunable group_idle Vivek Goyal
2010-08-16 18:53 ` Jeff Moyer
2010-08-11 22:44 ` [PATCH 4/5] cfq-iosched: blktrace print per slice sector stats Vivek Goyal
2010-08-11 22:44 ` [PATCH 5/5] cfq-iosched: Documentation help for new tunables Vivek Goyal
2010-08-16 19:00 ` Jeff Moyer
2010-08-17 12:50 ` Vivek Goyal
2010-08-17 13:51 ` Jeff Moyer
2010-08-23 10:26 ` [PATCH] cfq-iosched: cfq-iosched: Implement group idling and IOPS accounting for groups V4 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281566667-7821-2-git-send-email-vgoyal@redhat.com \
--to=vgoyal@redhat.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®