mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jon Masters <jcm@jonmasters.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jon Masters <jcm@jonmasters.org>
Subject: [PATCH] modules: don't call depmod when overriding external module install path
Date: Mon, 16 Aug 2010 04:03:34 -0400	[thread overview]
Message-ID: <1281945814-9720-1-git-send-email-jcm@jonmasters.org> (raw)

Recent kernels include an additional call to depmod during the installation
of external kernel modules as a convenience, in order to ensure that those
modules are picked up by the module loading tools/initramfs scripts, etc.
Although this call is potentially of some value, it should not be made
when explicitly setting INSTALL_MOD_PATH to a different location. This
avoids creating extraneous modules.* files that will never be used.

Signed-off-by: Jon Masters <jcm@jonmasters.org>
---
 Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index f3bdff8..2b904f2 100644
--- a/Makefile
+++ b/Makefile
@@ -1325,7 +1325,9 @@ _emodinst_:
 
 PHONY += _emodinst_post
 _emodinst_post: _emodinst_
+ifeq ($(INSTALL_MOD_PATH),)
 	$(call cmd,depmod)
+endif
 
 clean-dirs := $(addprefix _clean_,$(KBUILD_EXTMOD))
 
-- 
1.7.2.1


             reply	other threads:[~2010-08-16  8:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-16  8:03 Jon Masters [this message]
2010-08-16 10:43 ` Rusty Russell
2010-08-16 22:26   ` Jon Masters
2010-08-17  2:51   ` Américo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281945814-9720-1-git-send-email-jcm@jonmasters.org \
    --to=jcm@jonmasters.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®