From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Jon Masters <jcm@jonmasters.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] modules: don't call depmod when overriding external module install path
Date: Tue, 17 Aug 2010 10:51:44 +0800 [thread overview]
Message-ID: <20100817025144.GA5095@cr0.nay.redhat.com> (raw)
In-Reply-To: <201008162013.46252.rusty@rustcorp.com.au>
On Mon, Aug 16, 2010 at 08:13:45PM +0930, Rusty Russell wrote:
>On Mon, 16 Aug 2010 05:33:34 pm Jon Masters wrote:
>> Recent kernels include an additional call to depmod during the installation
>> of external kernel modules as a convenience, in order to ensure that those
>> modules are picked up by the module loading tools/initramfs scripts, etc.
>> Although this call is potentially of some value, it should not be made
>> when explicitly setting INSTALL_MOD_PATH to a different location. This
>> avoids creating extraneous modules.* files that will never be used.
>>
>> Signed-off-by: Jon Masters <jcm@jonmasters.org>
>
>Acked-by: Rusty Russell <rusty@rustcorp.com.au>
>
>I leave the Makefile stuff to the kbuild people...
>
Looks good for me,
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
prev parent reply other threads:[~2010-08-17 2:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 8:03 Jon Masters
2010-08-16 10:43 ` Rusty Russell
2010-08-16 22:26 ` Jon Masters
2010-08-17 2:51 ` Américo Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817025144.GA5095@cr0.nay.redhat.com \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jcm@jonmasters.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®