From: Ike Panhc <ike.pan@canonical.com>
To: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Cc: Thomas Renninger <trenn@suse.de>, Alan Cox <alan@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Corentin Chary <corentincj@iksaif.net>,
David Woodhouse <David.Woodhouse@intel.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Len Brown <len.brown@intel.com>, Matthew Garrett <mjg@redhat.com>
Subject: [PATCH 5/8] ideapad: use EC command to control camera
Date: Wed, 18 Aug 2010 16:38:15 +0800 [thread overview]
Message-ID: <1282120695-11503-1-git-send-email-ike.pan@canonical.com> (raw)
In-Reply-To: <1282120564-11324-1-git-send-email-ike.pan@canonical.com>
Signed-off-by: Ike Panhc <ike.pan@canonical.com>
---
drivers/platform/x86/ideapad_acpi.c | 16 +++++++++++-----
1 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/platform/x86/ideapad_acpi.c b/drivers/platform/x86/ideapad_acpi.c
index 673b44d..a1fdb45 100644
--- a/drivers/platform/x86/ideapad_acpi.c
+++ b/drivers/platform/x86/ideapad_acpi.c
@@ -35,6 +35,7 @@
#define IDEAPAD_DEV_KILLSW 4
struct ideapad_private {
+ acpi_handle handle;
struct rfkill *rfk[5];
};
@@ -209,24 +210,28 @@ static ssize_t show_ideapad_cam(struct device *dev,
struct device_attribute *attr,
char *buf)
{
- int state = ideapad_dev_get_state(IDEAPAD_DEV_CAMERA);
- if (state < 0)
- return state;
+ struct ideapad_private *priv = dev_get_drvdata(dev);
+ acpi_handle handle = priv->handle;
+ unsigned long result;
- return sprintf(buf, "%d\n", state);
+ if (read_ec_data(handle, 0x1D, &result))
+ return sprintf(buf, "-1\n");
+ return sprintf(buf, "%lu\n", result);
}
static ssize_t store_ideapad_cam(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t count)
{
+ struct ideapad_private *priv = dev_get_drvdata(dev);
+ acpi_handle handle = priv->handle;
int ret, state;
if (!count)
return 0;
if (sscanf(buf, "%i", &state) != 1)
return -EINVAL;
- ret = ideapad_dev_set_state(IDEAPAD_DEV_CAMERA, !!state);
+ ret = write_ec_cmd(handle, 0x1E, state);
if (ret < 0)
return ret;
return count;
@@ -337,6 +342,7 @@ static int ideapad_acpi_add(struct acpi_device *adevice)
}
}
+ priv->handle = adevice->handle;
dev_set_drvdata(&adevice->dev, priv);
for (i = IDEAPAD_DEV_WLAN; i <= IDEAPAD_DEV_KILLSW; i++) {
if (!devs_present[i])
--
1.7.0.4
next prev parent reply other threads:[~2010-08-18 8:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 8:36 [PATCH 0/8] [Resend] ideapad: using EC command to control rf/camera power Ike Panhc
2010-08-18 8:36 ` [PATCH 1/8] ideapad: add ACPI helpers Ike Panhc
2010-08-18 8:37 ` [PATCH 2/8] ideapad: check VPC bit before sync rfkill hw status Ike Panhc
2010-08-18 8:37 ` [PATCH 3/8] ideapad: make sure we bind on the correct device Ike Panhc
2010-08-18 13:27 ` Matthew Garrett
2010-08-19 2:51 ` Ike Panhc
2010-08-18 8:38 ` [PATCH 4/8] ideapad: use return value of _CFG to tell if device exist or not Ike Panhc
2010-08-18 8:38 ` Ike Panhc [this message]
2010-08-18 8:42 ` [PATCH 5/8] ideapad: use EC command to control camera Oliver Neukum
2010-08-18 8:51 ` Ike Panhc
2010-08-18 8:38 ` [PATCH 6/8] ideapad: rewrite the hw rfkill notify Ike Panhc
2010-08-18 8:38 ` [PATCH 7/8] ideapad: rewrite the sw rfkill set Ike Panhc
2010-08-18 8:38 ` [PATCH 8/8] ideapad: Change the driver name to ideapad_laptop Ike Panhc
2010-08-25 20:56 ` Len Brown
2010-08-26 5:43 ` Corentin Chary
2010-08-26 6:16 ` Ike Panhc
2010-08-26 7:43 ` Corentin Chary
2010-09-01 11:55 ` Ike Panhc
2010-08-18 10:35 ` [PATCH 0/8] [Resend] ideapad: using EC command to control rf/camera power David Woodhouse
2010-08-18 13:04 ` Ike Panhc
2010-08-18 15:51 ` Mario 'BitKoenig' Holbe
2010-08-19 3:21 ` Ike Panhc
2010-08-19 13:28 ` David Woodhouse
2010-08-19 19:31 ` Mario 'BitKoenig' Holbe
2010-08-20 7:01 ` Ike Panhc
2010-08-20 9:08 ` Mario 'BitKoenig' Holbe
2010-08-23 8:22 ` Ike Panhc
2010-08-25 11:59 ` Ike Panhc
2010-08-30 18:19 ` Mario 'BitKoenig' Holbe
2010-09-01 11:49 ` Ike Panhc
2010-09-01 19:56 ` Mario 'BitKoenig' Holbe
2010-09-03 9:06 ` Ike Panhc
2010-09-09 18:17 ` Mario 'BitKoenig' Holbe
2010-09-10 6:44 ` Ike Panhc
2010-09-10 7:11 ` Mario 'BitKoenig' Holbe
2010-09-15 10:13 ` Ike Panhc
2010-09-15 11:48 ` Mario 'BitKoenig' Holbe
2010-09-15 12:39 ` Ike Panhc
2010-09-16 11:59 ` Ike Panhc
2010-09-21 13:47 ` Mario 'BitKoenig' Holbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282120695-11503-1-git-send-email-ike.pan@canonical.com \
--to=ike.pan@canonical.com \
--cc=David.Woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=corentincj@iksaif.net \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®