mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Huang Ying <ying.huang@intel.com>
To: Stefani Seibold <stefani@seibold.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: number of elements or bytes for kfifo_in etc
Date: Thu, 19 Aug 2010 08:32:30 +0800	[thread overview]
Message-ID: <1282177950.2744.1587.camel@yhuang-dev> (raw)
In-Reply-To: <1282149358.5103.5.camel@wall-e.seibold.net>

Hi, Stefani,

On Thu, 2010-08-19 at 00:35 +0800, Stefani Seibold wrote:
> Am Mittwoch, den 18.08.2010, 13:29 +0800 schrieb Huang Ying:
> > Hi, Stefani,
> > 
> > In new kfifo implementation in 2.6.36-rc1, description of the third
> > parameter is:
> > 
> > "@n: number of elements to be added"
> > 
> > But if my understanding is correct, the actual implementation is:
> > 
> > "@n: number of bytes to be added"
> > 
> 
> Number of bytes is wrong, this is only valid for byte stream fifo's
> where an element is a byte.
> 
> Have a look at samples/kfifo/inttype-example.c where an element is a int
> type.

Yes. You are right. I misunderstood your code. Sorry for bothering.

Best Regards,
Huang Ying



  reply	other threads:[~2010-08-19  0:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18  5:29 Huang Ying
2010-08-18 16:35 ` Stefani Seibold
2010-08-19  0:32   ` Huang Ying [this message]
2010-08-19  1:15     ` Huang Ying
2010-08-19  6:52       ` Stefani Seibold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282177950.2744.1587.camel@yhuang-dev \
    --to=ying.huang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefani@seibold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®