From: Eric Dumazet <eric.dumazet@gmail.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: Bandan Das <bandan.das@stratus.com>,
David Miller <davem@davemloft.net>,
NetDev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB in ip_fragment
Date: Tue, 31 Aug 2010 11:17:51 +0200 [thread overview]
Message-ID: <1283246271.2550.35.camel@edumazet-laptop> (raw)
In-Reply-To: <20100831082444.GB29281@gondor.apana.org.au>
Le mardi 31 août 2010 à 16:24 +0800, Herbert Xu a écrit :
> On Tue, Aug 31, 2010 at 07:20:31AM +0200, Eric Dumazet wrote:
> > Le lundi 30 août 2010 à 19:21 -0400, Bandan Das a écrit :
> > > >
> > > > I wonder if we want this.
> > > >
> > > > Maybe setting skb->local_df = 1 in bridge should be enough ?
> > > >
> > > >
> > > Thanks Eric for looking at this. Indeed, setting local_df to 1 seems to be enough! I will
> > > respin and post a different patch.
> > >
> >
> > Reading this stuff again, I wonder if we should not revert commit
> > 17762060c25590bfddd and use a different trick
>
> I don't quite understand the problem. Does the packet actually
> have IP options? If not why is it trying to look at IP options?
>
> If it does have options, then we should parse options in the
> bridge driver before passing it to the IP stack (or just drop
> the packet).
Once again, the IP stack -> bridge -> IP stack flow bites us,
because bridge likes to dirty IPCB.
We can correct every bug we find once in a while (you did in commit
17762060c255 for a particular bug), or just make bridge not touch IPCB.
next prev parent reply other threads:[~2010-08-31 9:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 20:09 Bandan Das
2010-08-30 21:35 ` Eric Dumazet
2010-08-30 23:21 ` Bandan Das
2010-08-31 5:20 ` Eric Dumazet
2010-08-31 8:24 ` Herbert Xu
2010-08-31 9:17 ` Eric Dumazet [this message]
2010-08-31 12:36 ` Herbert Xu
2010-08-31 13:13 ` Eric Dumazet
2010-08-31 13:50 ` Bandan Das
2010-09-01 16:57 ` Bandan Das
2010-09-03 4:49 ` Herbert Xu
2010-09-15 17:32 ` Bandan Das
2010-09-17 6:51 ` Herbert Xu
2010-09-17 23:43 ` David Miller
2010-09-19 19:36 ` Bandan Das
2010-09-01 21:46 ` David Miller
2010-09-01 23:30 ` Herbert Xu
2010-09-02 1:09 ` David Miller
2010-09-02 2:05 ` Bandan Das
2010-09-02 2:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283246271.2550.35.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bandan.das@stratus.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®